Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Stop Changing the HTML Markup of a block #17509

Closed
hrsetyono opened this issue Sep 21, 2019 · 3 comments
Closed

Please Stop Changing the HTML Markup of a block #17509

hrsetyono opened this issue Sep 21, 2019 · 3 comments
Labels
[Block] Table Affects the Table Block [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@hrsetyono
Copy link

hrsetyono commented Sep 21, 2019

Few days ago I accidentaly updated Gutenberg plugin on a production site (I used Composer and just did composer update command)

Then today I realized some of my pages has messed up Gallery. Apparently now Gutenberg add an inner wrapper to Gallery block?

Other example is how Table is now wrapped inside figure. Which also messed up my styling.

<figure class="wp-block-table">
  <table>
    ...
  </table>
</figure>

Previously, it's like this:

<table class="wp-block-table">
  ...
</table>

I know this is a non-issue if I simply not update Gutenberg.

But some of my projects use core Gutenberg from WP 5.2. What if the next WP 5.3 has updated Gutenberg?

Please consider this before updating the core Gutenberg.

Thank you

@swissspidy swissspidy added [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Table Affects the Table Block and removed [Block] Gallery Affects the Gallery Block - used to display groups of images labels Sep 25, 2019
@swissspidy
Copy link
Member

Sometimes this cannot be avoided. For example, #16324 introduced this figure element to fix issues with accessibility and allow for further enhancements to blocks.

@hrsetyono
Copy link
Author

That's understandable. I will install old version of Gutenberg on my site to avoid the upcoming changes in WP 5.3.

But that Table zoom-level issue can be easily solved by adding display: block and overflow-x: auto to the table.

It doesn't feel right to change the display of table, but it does the job for my site.

Thanks

@talldan
Copy link
Contributor

talldan commented Sep 25, 2019

But that Table zoom-level issue can be easily solved by adding display: block and overflow-x: auto to the table.

@hrsetyono That's been tried previously with the table block, but it breaks table-layout: fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Feature] Block Validation/Deprecation Handling block validation to determine accuracy and deprecation [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

3 participants