-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button style suggestion: (rounded|squared)x(outlined|filled) #12699
Comments
From a design perspective I find it odd that "rounded" and "squared" have both made it in as default styling options for the button block. Generally I would expect you would want a consistent button style across a site, so that should be the job of a theme or site wide customiser setting, rather than having to style each button block individually? I guess it's in there now though and will be staying? It just means themes will have to unregister one of the styles if they don't need it. "Outlined" and "filled make sense as styling options to differentiate between an important primary and a secondary button. |
This ticket was discussed in this week's Design chat. The general consensus was that yes, the current options are weird. 😄 Historically, most themes (and websites in general) do not use both rounded and squared buttons. Removing one of those options would make a lot of sense here. Then, the options would be:
If themes wanted to implement additional options, they could include them as custom block styles. |
Wanted to plus one this idea. I recently came across this same problem where I wasn't able to both style a button squared and outlined and thought it was odd. |
It looks like #16481 is trying to address the same issue. Let's consolidate there. |
Now, the button block has 3 styles,
rounded
,squared
andoutlined
.Shouldn’t it be
(rounded|squared)x(outlined|filled)
?The text was updated successfully, but these errors were encountered: