Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button style suggestion: (rounded|squared)x(outlined|filled) #12699

Closed
cloudinstone opened this issue Dec 8, 2018 · 5 comments
Closed

Button style suggestion: (rounded|squared)x(outlined|filled) #12699

cloudinstone opened this issue Dec 8, 2018 · 5 comments
Labels
[Block] Buttons Affects the Buttons Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@cloudinstone
Copy link

Now, the button block has 3 styles, rounded, squared and outlined.

Shouldn’t it be (rounded|squared)x(outlined|filled) ?

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. Needs Testing Needs further testing to be confirmed. [Block] Buttons Affects the Buttons Block labels Dec 8, 2018
@kcalkmc
Copy link

kcalkmc commented Dec 9, 2018

I tested with WP 5.0. Screen confirms what you describe.
wp-issue-12699

It would be great to get designer feedback on this.

@designsimply designsimply added Needs Design Feedback Needs general design feedback. and removed Needs Testing Needs further testing to be confirmed. labels Dec 9, 2018
@benhuson
Copy link

From a design perspective I find it odd that "rounded" and "squared" have both made it in as default styling options for the button block. Generally I would expect you would want a consistent button style across a site, so that should be the job of a theme or site wide customiser setting, rather than having to style each button block individually? I guess it's in there now though and will be staying? It just means themes will have to unregister one of the styles if they don't need it.

"Outlined" and "filled make sense as styling options to differentiate between an important primary and a secondary button.

@kjellr
Copy link
Contributor

kjellr commented Apr 23, 2019

This ticket was discussed in this week's Design chat.

The general consensus was that yes, the current options are weird. 😄

Historically, most themes (and websites in general) do not use both rounded and squared buttons. Removing one of those options would make a lot of sense here. Then, the options would be:

  • Default (Filled. Would be either rounded or squared, depending on the theme's preference)
  • Outlined (Would be either rounded or squared, depending on the theme's preference)

If themes wanted to implement additional options, they could include them as custom block styles.

@enriquesanchez
Copy link
Contributor

Shouldn’t it be (rounded|squared)x(outlined|filled) ?

Wanted to plus one this idea. I recently came across this same problem where I wasn't able to both style a button squared and outlined and thought it was odd.

@youknowriad
Copy link
Contributor

It looks like #16481 is trying to address the same issue. Let's consolidate there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants