Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save reusable blocks on "Save" #11784

Closed
GlennMartin1 opened this issue Nov 12, 2018 · 5 comments · Fixed by #27887
Closed

Save reusable blocks on "Save" #11784

GlennMartin1 opened this issue Nov 12, 2018 · 5 comments · Fixed by #27887
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@GlennMartin1
Copy link

Saving a post/page should also first save edited reusable blocks.

To reproduce:

  1. On a page/post, edit a reusable block.
  2. Forget to hit "save" on the reusable block.
  3. Save the page/post.
  4. Note that the reusable block edit is lost.

It seems expected behavior is that the edited reusable block would be automatically saved in the page/post Save.

Using 4.3.0.

@designsimply designsimply added [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Testing Needs further testing to be confirmed. labels Nov 13, 2018
@molszewska
Copy link

I couldn't see the option to edit the reusable block. However, while creating a new reusable block, I didn't save its title and I published the page - the block was preserved.

@sourourn
Copy link

Same for me ^. There was no option to edit the re-usable block once it was added. The edit button is greyed out.
Screen Shot on 2019-05-12 at 10-56-39

WordPress Version 5.2
Browser: Firefox 61.0.2
Mac OS

@mlbrgl
Copy link
Contributor

mlbrgl commented Aug 28, 2019

On 5.2.2, I am seeing both behaviours described:

  • @GlennMartin1: on editing a previously added reusable block + save post
    Result: reusable block edits are lost

  • @molszewska: on creating a new reusable block + save post
    Result: reusable block edits are preserved, title is lost (defaults to "Untitled Reusable Block")

In both cases, the reusable block "Save" button is bypassed. In both cases, the expected result is that reusable blocks edits are preserved (including their respective title).

@skorasaurus
Copy link
Member

I can confirm @GlennMartin1 's bug on Gutenberg 7.5.0 (WP 5.3.2); the 'needs testing' label can be removed.

@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. and removed Needs Testing Needs further testing to be confirmed. labels Apr 20, 2020
@noisysocks
Copy link
Member

Yes, this is a flaw in the current design of Reusable Blocks.

I'd like to see this issue addressed by incorporating Reusable Blocks into the "Update Design" flow being worked on in #20421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants