Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encounter.state SiteSettings API addition #627

Closed
TanyaStere42 opened this issue Jul 1, 2024 · 1 comment · Fixed by #747
Closed

encounter.state SiteSettings API addition #627

TanyaStere42 opened this issue Jul 1, 2024 · 1 comment · Fixed by #747
Assignees
@PAVANA809
Labels
enhancement new or improvements on existing features good first issue small, contained tasks that can be done with minimal onboarding modernization Updating the tech stack iteratively

Comments

@TanyaStere42
Copy link
Member

TanyaStere42 commented Jul 1, 2024 •
edited by naknomum
Loading

Feature description and context

In support of the React front end, we need APIs for all valid value lists. encounter.state is one of them!
Note: related to #626, but not dependent.

Feature sign-off requirements

  • GET the encounter state via the SiteSettings API, which can have one of the following values:
    • unapproved (default)
    • approved
    • unidentifiable

Technical Notes

  • functionality shall be extended in the existing api/SiteSettings.java servlet, using the api key encounterStates
  • use a hard-coded array of strings for the values (defined as a class variable). however please put a note in a comment above it that historically this list was generated via CommonConfiguration using List<String> states = CommonConfiguration.getIndexedPropertyValues("encounterState",context)
  • see sex being set via VALUES_SEX = { "unknown", "male", "female" } as an example.
@TanyaStere42 TanyaStere42 added enhancement new or improvements on existing features modernization Updating the tech stack iteratively labels Jul 1, 2024
@naknomum naknomum changed the title encounter.state API encounter.state SiteSettings API addition Jul 1, 2024
@naknomum naknomum added the good first issue small, contained tasks that can be done with minimal onboarding label Jul 1, 2024
@PAVANA809
Copy link
Contributor

Generated pull request
#747

@TanyaStere42 TanyaStere42 linked a pull request Sep 8, 2024 that will close this issue
[ISSUE-627]Encounter state api enhancement #747
Merged
@PAVANA809 PAVANA809 mentioned this issue Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PAVANA809 PAVANA809

Labels
enhancement new or improvements on existing features good first issue small, contained tasks that can be done with minimal onboarding modernization Updating the tech stack iteratively
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE-627]Encounter state api enhancement PAVANA809/Wildbook
3 participants
@naknomum @TanyaStere42 @PAVANA809