Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to make event indicators have different colors each? #217

Closed
cyrilzakka opened this issue Feb 23, 2016 · 21 comments
Closed

Comments

@cyrilzakka
Copy link

Rather than having a single color for all event indicators, would it be possible to have different colors for each event depending on the nature of the event for example?

@WenchaoD
Copy link
Owner

Actually you can put different event-colors for different days. See the "Delegate Appearance Example" for details.

@WenchaoD
Copy link
Owner

@Archivus Or you want different event-colors for one single day?

@cyrilzakka
Copy link
Author

The latter :) @WenchaoIOS

@WenchaoD
Copy link
Owner

You are right @Archivus I'll figure out a solution

@Vortec4800
Copy link

I would like this functionality as well - multiple event colors on the same day. Just adding my vote.

@willzcc
Copy link

willzcc commented Mar 10, 2016

@Vortec4800 try to draw a custom UIImage for substitute below the date if you want this functionality in rush then call the delegate method.

@anthonycastelli
Copy link

Has any progress been made on this? I need this for a project so I'd have a look at implementing it if there is no progress.

@cyrilzakka
Copy link
Author

@anthonycastelli I don't mean to sound rude, but don't rush @WenchaoD. He works on this during his free time... Why not move on to other aspects of your projects while waiting for this?

@anthonycastelli
Copy link

@Archivus Im at the end of my project but I was just wondering if he started it, that way if he did I would let him finish, otherwise I would move forward and look into implementing it and submitting a PR. I wasn't rushing his at all. Was just looking for a progress report on it.

@willzcc
Copy link

willzcc commented Mar 19, 2016

@anthonycastelli guess not and looking forward to you PR

@anthonycastelli
Copy link

@wyattzhang I implemented it here if you want to take a look. anthonycastelli@edea77b
I feel like there is a better way of doing this https://github.com/anthonycastelli/FSCalendar/blob/edea77be218c7faf01f2e13942fabedb1b99da70/FSCalendar/FSCalendarEventIndicator.m#L83-#L88 though. I'll experiment with another solution I have before I submit a PR.

@WenchaoD
Copy link
Owner

Hi guys. Do you think this functionality is also necessary?

@anthonycastelli
Copy link

Given size of the event indicators this might look a little funky as it would be a super tiny dot, but since its just a CALayer this is easy to add.

@anthonycastelli
Copy link

I've submitted a PR. #234 It was the best option for what I needed as it allowed the most customization.

@cyrilzakka
Copy link
Author

@WenchaoD As @anthonycastelli mentioned, it would be useless as the dots are tiny - it would make for bad UX as the user would have to strain his eyes and the information wouldn't be apparent at a single glance.

@willzcc
Copy link

willzcc commented Mar 20, 2016

@anthonycastelli thanks
@Archivus Event indicators do strain user's eyes but free the hands of someone who really need this functionality like @anthonycastelli and they can decide to use or not themselves .
@WenchaoD for the framework given the customizability of event indicators would be a plus indeed.

@anthonycastelli
Copy link

@wyattzhang My pleasure. Regarding the outline on the dots, I left a comment with an idea on #225

@cyrilzakka
Copy link
Author

@wyattzhang I agree but then you'd have to add resizing event indicators, be able to modify the space between indicators and events, etc. These all seem pretty easy from my scouring of the files.

@willzcc
Copy link

willzcc commented Mar 21, 2016

sorry ... but ... the author has already done these dirty works for you although with some limitations

@WenchaoD
Copy link
Owner

Fixed..

@rackNeha
Copy link

rackNeha commented Oct 25, 2017

Hello ,
I'm using FSCalendar for attendance module.I have two issues :
1. I want to show different colors for different days for eg: 1st Oct i have done Time In - Out both so it should SHOW Green DOT
2nd Oct i have done only Time In - So it should show Yellow DOT like wise.
2. Weekend should contain Sunday ONLY not Saturday
Please help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@Vortec4800 @cyrilzakka @anthonycastelli @WenchaoD @rackNeha @willzcc and others