Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📲 Download #30

Merged
merged 7 commits into from
Jul 20, 2023
Merged

📲 Download #30

merged 7 commits into from
Jul 20, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented May 22, 2023

Download

Adds ci download command

  • --proxy: the type of proxy to download
  • --output: the output file

Usage

 Usage: ci download [OPTIONS] ID

 Download a file from Sony CI

╭─ Arguments ─────────────────────────────────────────────────────────────────────────────────────────────╮
│ *    id      TEXT  The SonyCi ID of the file to download [default: None] [required]                     │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─ Options ───────────────────────────────────────────────────────────────────────────────────────────────╮
│ --proxy   -p      [document-pdf|video-sd|video-3g]  Download [default: None]                            │
│ --output  -o      PATH                              The path to download the file to [default: None]    │
│ --help    -h                                        Show this message and exit.                         │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────╯

@mrharpo mrharpo added the enhancement ➕ New feature or request label May 22, 2023
@mrharpo mrharpo added this to the v0.2.0 Routes 🛣 milestone May 22, 2023
@mrharpo mrharpo requested a review from afred May 22, 2023 21:27
@mrharpo mrharpo self-assigned this May 22, 2023
@mrharpo mrharpo temporarily deployed to Codecov May 22, 2023 21:28 — with GitHub Actions Inactive
@mrharpo mrharpo changed the base branch from main to docker May 22, 2023 21:28
@mrharpo mrharpo changed the base branch from docker to main May 22, 2023 21:28
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #30 (b8b5a11) into main (0cfa16c) will decrease coverage by 5.14%.
The diff coverage is 40.74%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   82.19%   77.06%   -5.14%     
==========================================
  Files           7        8       +1     
  Lines         191      218      +27     
==========================================
+ Hits          157      168      +11     
- Misses         34       50      +16
Impacted Files Coverage Δ
sonyci/cli.py 54.54% <27.27%> (-9.10%) ⬇️
sonyci/types.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo temporarily deployed to Codecov May 22, 2023 21:30 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov May 22, 2023 21:30 — with GitHub Actions Inactive
afred
afred approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrharpo
Merge branch 'main' into download
ea1c19b 
* main:
  🪣 `ci asset` (#29)
  🤖 Update dependencies (#27)
@mrharpo mrharpo temporarily deployed to Codecov July 20, 2023 21:22 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov July 20, 2023 21:22 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov July 20, 2023 21:39 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov July 20, 2023 21:39 — with GitHub Actions Inactive
@mrharpo mrharpo merged commit 38dbce3 into main Jul 20, 2023
@mrharpo mrharpo deleted the download branch July 20, 2023 21:40
mrharpo added a commit that referenced this pull request Jul 20, 2023
@mrharpo
Merge branch 'main' into tui
394e882 
* main:
  📲 Download (#30)
  🪣 `ci asset` (#29)
  🤖 Update dependencies (#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
enhancement ➕ New feature or request
Projects
No open projects
Chowda 2023
Status: ✅ Done
Milestone
v0.2.0 Routes 🛣
Development

Successfully merging this pull request may close these issues.
3 participants
@mrharpo @codecov-commenter @afred