Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗞️ Configure frontend for dev #32

Merged
merged 3 commits into from
Aug 24, 2022
Merged

🗞️ Configure frontend for dev #32

merged 3 commits into from
Aug 24, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Aug 11, 2022

Frontend dev

With ov-frontend PR#6:

  • Use dev image for local development in docker-compose.yml
  • Migrate to CMD npm run dev for dev image
  • Only copy all files in production

@mrharpo mrharpo added bug 🐛 Something isn't working maintenance 🔧 Updates and upgrades labels Aug 11, 2022
@mrharpo mrharpo added this to the v0.2.0 Deploy 🌇 milestone Aug 11, 2022
@mrharpo mrharpo requested a review from foglabs August 11, 2022 20:55
@mrharpo mrharpo self-assigned this Aug 11, 2022
@mrharpo mrharpo mentioned this pull request Aug 12, 2022
Merged
@mrharpo mrharpo changed the title Configure frontend for dev 🗞️ Configure frontend for dev Aug 24, 2022
@mrharpo mrharpo requested a review from afred August 24, 2022 19:12
afred
afred approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 01fb38c into main Aug 24, 2022
@afred afred deleted the front-docker-dev branch August 24, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

@foglabs foglabs Awaiting requested review from foglabs

Assignees

@mrharpo mrharpo

Labels
bug 🐛 Something isn't working maintenance 🔧 Updates and upgrades
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.2.0 Deploy 🌇
Development

Successfully merging this pull request may close these issues.
2 participants
@mrharpo @afred