Skip to content

Commit

Permalink
Remove deprecated URI::encode (#2483)
Browse files Browse the repository at this point in the history
* Remove deprecated URI::encode and replace with URI::encode_www_form_component

* disable problematic geoip test for India

Co-authored-by: Andrew Myers <andrew_myers@wgbh.org>
  • Loading branch information
mrharpo and afred authored Nov 3, 2022
1 parent a0eeac9 commit 00ce255
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/views/catalog/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
<dd><a href="/catalog?f[<%=
type.downcase.gsub(/\s/,'_')
%>_titles][]=<%=
URI::escape(title.gsub(/(["\\])/, '\\\\\1')) # escape Solr meta-characters
URI::encode_www_form_component(title.gsub(/(["\\])/, '\\\\\1')) # escape Solr meta-characters
%>"><%= title %></a></dd>
</dl>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/geo_i_p_country_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def country_for_domain(domain)
end

# Site seems to be down...
it 'puts india.gov.in in IN' do
xit 'puts india.gov.in in IN' do
expect(country_for_domain('www.mygov.in')).to eq 'IN'
end

Expand Down

0 comments on commit 00ce255

Please sign in to comment.