Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect state on nested HardDependencyNode if the child is created before the parent #99

Closed
Samuel-amap opened this issue Oct 7, 2024 · 1 comment · Fixed by #83
Closed
Labels
bug Something isn't working low priority

Comments

@Samuel-amap
Copy link
Collaborator

In cases where a HardDependencyNode's parent is also a HardDependencyNode, and the child is created before the parent, when the actual node is instantiated, it uses the incomplete parent state (which will not have had its parent and children properly set), leaving the instantiated node in an incorrect state that is not subsequently corrected once the parent is created.

This isn't currently a major issue, as it is easy to workaround, and graph traversal is almost always from a top-down direction, in which the state is correct, but in a multi scale context with more complex hard dependencies, it might creep up more often.

@Samuel-amap
Copy link
Collaborator Author

I exposed this issue with a 5-model toy demo with a 3-layer, 3-model hard dependency and prototype code that was meant to iterate over all the hard dependency nodes to access their soft dependency ancestor.

@Samuel-amap Samuel-amap added bug Something isn't working low priority labels Oct 7, 2024
@Samuel-amap Samuel-amap linked a pull request Oct 11, 2024 that will close this issue
@VEZY VEZY closed this as completed in #83 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant