-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update heatmap.py #78
Conversation
changed float16 to float32 while dividing mask with 255. speeds up the performance of detection postprocessing
Thanks for the PR! Where are you seeing the speedup? In the layout benchmark, I saw no real change (running on an M1 Mac). I ran float32
float16
|
Its in text line detection module using segformer. When the lines are huge in number. As in layout there aren't enough detections compared to line detections in newspaper like document. |
The layout benchmark does text detection (and the layout model also uses segformer and the same postprocessing script). What pdf were you testing on? Do you mind sharing? |
Thanks for the detailed benchmarks! Merging now. |
Hi @siddhawan apologies for pinging you again, but it turns out I need people to sign a CLA for this project. You can find it here. If you agree, please comment with "I have read the CLA Document and I hereby sign the CLA". If you don't agree, I may have to rewrite your contribution. Thanks again for taking the time to fix this issue. |
I have read the CLA document and I hereby sign the CLA |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
recheck |
hi, i'm using mac m2, how to use gpu ? or it just work ? Thanks |
changed float16 to float32 while dividing mask with 255. speeds up the performance of detection postprocessing. More than 2x speed.