Merge pull request Expensify#45320 from Expensify/srikar-renameOnyxKey

Rename Onyx Key

Author: srikarparsi

src/libs/ReportUtils.ts

@@ -1268,7 +1268,7 @@ function isClosedExpenseReportWithNoExpenses(report: OnyxEntry<Report>): boolean
  */
 function isArchivedRoom(report: OnyxInputOrEntry<Report>, reportNameValuePairs?: OnyxInputOrEntry<ReportNameValuePairs>): boolean {
     if (reportNameValuePairs) {
-        return reportNameValuePairs.isArchived;
+        return reportNameValuePairs.private_isArchived;
     }
 
     return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && report?.stateNum === CONST.REPORT.STATE_NUM.APPROVED;

src/types/onyx/ReportNameValuePairs.ts

@@ -3,7 +3,8 @@ import type * as OnyxCommon from './OnyxCommon';
 /** Model of additional report details */
 type ReportNameValuePairs = OnyxCommon.OnyxValueWithOfflineFeedback<{
     /** Whether the report is an archived room */
-    isArchived: boolean;
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    private_isArchived: boolean;
 }>;
 
 export default ReportNameValuePairs;