Merge pull request Expensify#44458 from Expensify/rodrigo-fix-hold-banner

rlinoz · web-flow · commit 060160e892b9 · 2024-06-26T10:57:40.000-03:00
Fix HOLD banner when deleting last expense on report
diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
@@ -6556,7 +6556,7 @@ function hasHeldExpenses(iouReportID?: string): boolean {
  */
 function hasOnlyHeldExpenses(iouReportID: string, transactions?: OnyxCollection<Transaction>): boolean {
     const reportTransactions = TransactionUtils.getAllReportTransactions(iouReportID, transactions);
-    return !reportTransactions.some((transaction) => !TransactionUtils.isOnHold(transaction));
+    return reportTransactions.length > 0 && !reportTransactions.some((transaction) => !TransactionUtils.isOnHold(transaction));
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -6556,7 +6556,7 @@ function hasHeldExpenses(iouReportID?: string): boolean {`
`6556`	`6556`	`*/`
`6557`	`6557`	`function hasOnlyHeldExpenses(iouReportID: string, transactions?: OnyxCollection<Transaction>): boolean {`
`6558`	`6558`	`const reportTransactions = TransactionUtils.getAllReportTransactions(iouReportID, transactions);`
`6559`		`- return !reportTransactions.some((transaction) => !TransactionUtils.isOnHold(transaction));`
	`6559`	`+ return reportTransactions.length > 0 && !reportTransactions.some((transaction) => !TransactionUtils.isOnHold(transaction));`
`6560`	`6560`	`}`
`6561`	`6561`
`6562`	`6562`	`/**`