Handle TLSv1.2 record version handshakes (16 03 03). #353

ValdikSS · ValdikSS · commit 4c846c712dfe · 2024-05-30T21:02:16.000+03:00
diff --git a/src/goodbyedpi.c b/src/goodbyedpi.c
@@ -1129,7 +1129,7 @@ int main(int argc, char *argv[]) {
                      * But if the packet is more than 2 bytes, check ClientHello byte.
                     */
                     if ((packet_dataLen == 2 && memcmp(packet_data, "\x16\x03", 2) == 0) ||
-                        (packet_dataLen >= 3 && memcmp(packet_data, "\x16\x03\x01", 3) == 0))
+                        (packet_dataLen >= 3 && ( memcmp(packet_data, "\x16\x03\x01", 3) == 0 || memcmp(packet_data, "\x16\x03\x03", 3) == 0 )))
                     {
                         if (do_blacklist) {
                             sni_ok = extract_sni(packet_data, packet_dataLen,

Original file line number	Diff line number	Diff line change
`@@ -1129,7 +1129,7 @@ int main(int argc, char *argv[]) {`
`1129`	`1129`	`* But if the packet is more than 2 bytes, check ClientHello byte.`
`1130`	`1130`	`*/`
`1131`	`1131`	`if ((packet_dataLen == 2 && memcmp(packet_data, "\x16\x03", 2) == 0) \|\|`
`1132`		`- (packet_dataLen >= 3 && memcmp(packet_data, "\x16\x03\x01", 3) == 0))`
	`1132`	`+ (packet_dataLen >= 3 && ( memcmp(packet_data, "\x16\x03\x01", 3) == 0 \|\| memcmp(packet_data, "\x16\x03\x03", 3) == 0 )))`
`1133`	`1133`	`{`
`1134`	`1134`	`if (do_blacklist) {`
`1135`	`1135`	`sni_ok = extract_sni(packet_data, packet_dataLen,`