Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor blinking before move to target line when use Nj or Nk when N, and seems like slow #2468

Open
maple-leaf opened this issue Mar 23, 2018 · 2 comments

Comments

@maple-leaf
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

What happened: cursor blinking before move to target line when use Nj or Nk, and seems like slow

What did you expect to happen: should target to N line down/up when Nj or Nk directly without blinking cursor

How to reproduce it (as minimally and precisely as possible):

  • open new window in vscode
  • copy page content from https://github.com/VSCodeVim/Vim
  • goto edit mode, paste text inside vscode, file type should be text(try to make test simple without affected by other plugins)
  • back to normal mode
  • jumping by 10j, 20k, you will find the bigger N, blinking will take more time.

screenshot:

untitled3

Environment:

vscode configuration relative to vscodevim:

/* Vim */
    "vim.enableNeovim": true,
    "vim.neovimPath": "/usr/local/bin/nvim",
    "vim.easymotion": true,
    "vim.incsearch": true,
    "vim.useSystemClipboard": false,
    "vim.useCtrlKeys": true,
    "vim.hlsearch": true,
    "vim.overrideCopy": false,
    "vim.foldfix": true,
    "editor.lineNumbers": "relative",
    "vim.insertModeKeyBindings": [
        {
            "before": [
                "j",
                "j"
            ],
            "after": [
                "<Esc>"
            ]
        }
    ],
    "vim.otherModesKeyBindingsNonRecursive": [
        {
            "before": [
                "u"
            ],
            "after": [],
            "commands": [
                {
                    "command": "undo",
                    "args": []
                }
            ]
        },
        {
            "before": [
                "<C-r>"
            ],
            "after": [],
            "commands": [
                {
                    "command": "redo",
                    "args": []
                }
            ]
        },
        {
            "before": [
                "<leader>",
                "e",
                "n"
            ],
            "commands": [
                {
                    "command": "editor.action.marker.next"
                }
            ]
        },
        {
            "before": [
                "<leader>",
                "e",
                "p"
            ],
            "commands": [
                {
                    "command": "editor.action.marker.prev"
                }
            ]
        },
        {
            // not working
            "before": [
                "<leader>",
                "e",
                "c"
            ],
            "commands": [
                {
                    "command": "closeMarkersNavigation"
                }
            ]
        }
    ],
    "vim.leader": "<space>",
    "vim.handleKeys": {
        "<C-a>": false,
        "<C-f>": true,
        "<C-n>": false
    },
  • Extension (VsCodeVim) version: 0.11.2
  • VSCode version: 1.21.1
  • OS version: macOS 10.13.3
@jcheng31
Copy link

jcheng31 commented Mar 28, 2018

I noticed this behaviour as well, and disabling vim.foldFix seems to resolve it.

(Running version 0.11.2 on VSCode 1.21.1, on macOS 10.13.3 too. It looks like this is the same issue as #2163?)

@chulander
Copy link

thanks @jcheng31 , that fixed it for me.

was wondering why it started happening after an upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants