Merge pull request #1333 from lesserwhirls/nids

Add support for NIDS product code 180

Author: lesserwhirls

cdm/src/main/java/ucar/nc2/iosp/nids/Nidsheader.java

@@ -1729,7 +1729,7 @@ int pcode_radial( ByteBuffer  bos, int hoff, int hedsiz, boolean isZ, byte[] dat
         addParameter(vName, lName, ncfile, dims1, att, DataType.DOUBLE, "milliseconds since 1970-01-01 00:00 UTC"
                     ,hoff, hedsiz, isZ, 0);
         //add RAW, BRIT variables for all radial variable
-        if(pcode == 182 || pcode == 99 ) {
+        if(pcode == 182 || pcode == 99 || pcode == 180) {
             levels = getTDWRLevels(nlevel, threshold);
             iscale = 10;
         } else if (pcode == 186 || pcode == 94) {
@@ -3243,7 +3243,7 @@ Pinfo read_proddesc(  ByteBuffer buf, int offset ){
         p3 = (short)getInt(b2, 2);
         off += 40;
         if(pcode == 182 || pcode == 186 || pcode == 32
-                || pcode == 94 || pcode == 99) {
+                || pcode == 94 || pcode == 99 || pcode == 180) {
           for(int i = 0; i< 16; i++) {
             buf.get(b2, 0, 2);
             threshold[i] = (short)bytesToInt(b2[0], b2[1], false);
@@ -3947,7 +3947,7 @@ static double code_reslookup( int code )
         0,    0,    0,    0,    0,    0,    0,    0,    0, 0.25,    /* 150-159 */
         0, 0.25,    0, 0.25,    0, 0.25,    0,    0,    0,    2,    /* 160-169 */
      0.25,    2, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25,    0,    0,    /* 170-179 */
-        0,  150.0, 150.0, 0,    0,    0, 300.0,   0,    0,    0,    /* 180-189 */
+        150.0,  150.0, 150.0, 0,    0,    0, 300.0,   0,    0,    0,    /* 180-189 */
       };
 
 
@@ -3989,7 +3989,7 @@ static int code_levelslookup( int code )
         0,    0,    0,    0,    0,    0,    0,    0,    0,  256,    /* 150-159 */
         0,  256,    0,  256,    0,  256,    0,    0,    0,   16,    /* 160-169 */
       256,   16,  256,  256,    0,    0,    0,   16,    0,    0,    /* 170-179 */
-        0,   16,  256,    0,    0,    0,  256,    0,    0,    0,    /* 180-189 */
+        256,   16,  256,    0,    0,    0,  256,    0,    0,    0,    /* 180-189 */
       };
 
 

cdm/src/test/data/nids/Level3_TUL_TZ0_20200811_1804.nids

@@ -33,7 +33,9 @@
 package ucar.nc2.iosp.nids;
 
 import junit.framework.*;
+import org.junit.Assert;
 import ucar.ma2.*;
+import ucar.ma2.MAMath.MinMax;
 import ucar.nc2.*;
 import ucar.unidata.util.test.TestDir;
 
@@ -413,6 +415,28 @@ public void testNidsReadDPA() throws IOException {
     ncfile.close();
   }
 
+  public void testRadialImageMessagePcode180() throws IOException {
+    // Radial Image message, product code 180 (TDWR)
+    double comparisonTolerance = 0.1;
+    String basereflect180TdwrFile = TestDir.cdmLocalTestDataDir + "nids/Level3_TUL_TZ0_20200811_1804.nids";
+    try (NetcdfFile ncf = NetcdfFile.open(basereflect180TdwrFile)) {
+      Variable bref = ncf.findVariable("BaseReflectivity");
+      Array data = bref.read();
+      double max = MAMath.getMaximum(data);
+      // max reflectivity value as shown by NWS web display at the time
+      // not a *great* check, but not the worst either.
+      Assert.assertTrue(Math.abs(max - 56.5) < comparisonTolerance);
+      // test that range of the radial axis variable is good
+      // expect 0 to 48 nautical miles (according to the ICD)
+      // which is roughly 0 to 88650 meters
+      Variable gate = ncf.findVariable("gate");
+      Array gateValues = gate.read();
+      MinMax minMax = MAMath.getMinMax(gateValues);
+      Assert.assertTrue(Math.abs(minMax.min) < comparisonTolerance);
+      Assert.assertTrue(Math.abs(minMax.max - 88650) < comparisonTolerance);
+    }
+  }
+
   private void testReadData(Variable v) {
     Array a = null;
     assert(null != v);