Skip to content

Commit 146c46e

Browse files
committed
ENH: Add some more supported service aliases
DODS is considered an alias for OPENDAP. Also add (legacy) support for 'http' as a synonym for HTTPServer.
1 parent 13ccb9f commit 146c46e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/siphon/catalog.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,8 @@ def remote_access(self, service=None, use_xarray=None):
670670
if service is None:
671671
service = 'CdmRemote' if 'CdmRemote' in self.access_urls else 'OPENDAP'
672672

673-
if service not in (CaseInsensitiveStr('CdmRemote'), CaseInsensitiveStr('OPENDAP')):
673+
if service not in (CaseInsensitiveStr('CdmRemote'), CaseInsensitiveStr('OPENDAP'),
674+
CaseInsensitiveStr('DODS')):
674675
raise ValueError(service + ' is not a valid service for remote_access')
675676

676677
return self.access_with_service(service, use_xarray)
@@ -735,7 +736,7 @@ def access_with_service(self, service, use_xarray=None):
735736
else:
736737
from .cdmr import Dataset as CDMRDataset
737738
provider = CDMRDataset
738-
elif service == 'OPENDAP':
739+
elif service == 'OPENDAP' or service == 'DODS':
739740
if use_xarray:
740741
try:
741742
import xarray as xr
@@ -753,7 +754,7 @@ def access_with_service(self, service, use_xarray=None):
753754
elif service in self.ncss_service_names:
754755
from .ncss import NCSS
755756
provider = NCSS
756-
elif service == 'HTTPServer':
757+
elif service == 'HTTPServer' or service == CaseInsensitiveStr('http'):
757758
provider = session_manager.urlopen
758759
else:
759760
raise ValueError(service + ' is not an access method supported by Siphon')

0 commit comments

Comments
 (0)