Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins should be installed by default when zstd is found by autotools, like the CMake build does #2967

Closed
edwardhartnett opened this issue Aug 7, 2024 · 0 comments · Fixed by #2973

Comments

@edwardhartnett
Copy link
Contributor

edwardhartnett commented Aug 7, 2024

We look for zstd and if we find it, we turn on zstd.

But then we don't install plugins unless the user explicitly tells us to. So zstd will be broken.

What would make more sense would be to install the plugins by default, if zstd is found, in the default location. This will cause zstd to automatically work for users who don't want to worry about HDF5_PLUGIN_PATH.

Users that do want to care about the plugin path can still install plugins where they like, and use the HDF5_PLUGIN_PATH to specify their location. But if the user doesn't say, let's just install plugins in the default location.

The CMake build actually does the correct thing, defaulting to install the plugins in the default plugin directory.

@edwardhartnett edwardhartnett changed the title plugins should be installed by default... plugins should be installed by default when zstd is found Aug 7, 2024
@edwardhartnett edwardhartnett changed the title plugins should be installed by default when zstd is found plugins should be installed by default when zstd is found by autotools, like the CMake build does Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant