Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[derivatives] Treat num in sdk.Dec when it's in Metrics And Rename functions appropriately #504

Closed
taiki1frsh opened this issue Apr 25, 2023 · 0 comments
Closed

[derivatives] Treat num in sdk.Dec when it's in Metrics And Rename functions appropriately #504

taiki1frsh opened this issue Apr 25, 2023 · 0 comments
Assignees
@taiki1frsh

Comments

@taiki1frsh
Copy link
Collaborator

taiki1frsh commented Apr 25, 2023 •
edited
Loading

Currently, "InMetrics" word in a function means it's treated in "USD", not micro unit.

So, modify them int sdk.Dec type

And, Create unit tests for the important fns in position.go under types package.
@taiki1frsh taiki1frsh self-assigned this Apr 25, 2023
@taiki1frsh taiki1frsh changed the title [derivatives] Treat num in sdk.Dec when it's in Metrics [derivatives] Treat num in sdk.Dec when it's in Metrics And Rename functions appropriately Apr 26, 2023
@taiki1frsh taiki1frsh mentioned this issue Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki1frsh taiki1frsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taiki1frsh