Skip to content

Commit adc4c59

Browse files
Diana GergelJoe Hamman
Diana Gergel
authored and
Joe Hamman
committed
Feature/fix latent heat and longwave coupler fields (#695)
* fix sign for latent heat * fix sign for longwave up * change log entry for cesm_put_data changes * update to correct PR #
1 parent ae4e67d commit adc4c59

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

docs/Development/ReleaseNotes.md

+8-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ To check which release of VIC you are running:
2525

2626
Drainage from upper layer to adjacent lower layer is calculated according to Brook & Corey curve (where drainage rate is a function of upper-layer soil moisture). In previous versions, a simple numerical solution is applied which uses the timestep-beginning upper-layer soil moisture to calculate drainage rate, and assume this constant rate over the entire timestep. This can cause unreasonably large drainage if the curve has a steep shape and when soil moisture is high. Now, the current version uses exact integral (instead of numerical solution) for layer drainage calculation.
2727

28-
2. Fixes for the CESM driver ([GH#642](https://github.com/UW-Hydro/VIC/pull/642))
28+
2. Fixes for the CESM driver
29+
30+
[GH#642](https://github.com/UW-Hydro/VIC/pull/642)
2931

3032
1. Using correct fill value datatypes in MPI Gather steps
3133
2. Updated state file name time step to be period-ending rather than period-beginning
@@ -36,10 +38,14 @@ To check which release of VIC you are running:
3638
7. Fixed bug that prevented using the correct local domain grid cells in `cesm_put_data.c`
3739
8. Changed reference temperature units from Celsius to Kelvin in `cesm_put_data.c`
3840

41+
[GH#695](https://github.com/UW-Hydro/VIC/pull/695)
42+
43+
1. Fix sign for latent heat fluxes passed from VIC to the coupler
44+
2. Fix sign for longwave radiation passed from VIC to the coupler
45+
3946
[GH#696](https://github.com/UW-Hydro/VIC/pull/696)
4047

4148
1. Changes names of CESM driver functions `trim` and `advance_time` to `trimstr` and `advance_vic_time`, respectively, to avoid conflicts with WRF functions with the same names when compiling RFR case.
42-
------------------------------
4349

4450
## VIC 5.0.1
4551

vic/drivers/cesm/src/cesm_put_data.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ vic_cesm_put_data()
249249

250250
// latent heat flux
251251
// CESM units: W m-2
252-
l2x_vic[i].l2x_Fall_lat += -1 * AreaFactor * energy.AtmosLatent;
252+
l2x_vic[i].l2x_Fall_lat += AreaFactor * energy.AtmosLatent;
253253

254254
// sensible heat flux
255255
// CESM units: W m-2
@@ -258,7 +258,7 @@ vic_cesm_put_data()
258258

259259
// upward longwave heat flux
260260
// CESM units: W m-2
261-
l2x_vic[i].l2x_Fall_lwup += AreaFactor *
261+
l2x_vic[i].l2x_Fall_lwup += -1 * AreaFactor *
262262
(force[i].longwave[NR] -
263263
energy.NetLongAtmos);
264264

0 commit comments

Comments
 (0)