Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

312 feature request display a line graph of gpa over time #356

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

312 feature request display a line graph of gpa over time #356

wants to merge 15 commits into from

Conversation

sparklingwter
Copy link
Contributor

Overview

resolves issue 312

What Changed

line graph and toggle buttons shows gpa trend of a course

sparklingwter and others added 14 commits February 3, 2025 15:29
@sparklingwter
line graph that displays GPA over time
120a8e7
@sparklingwter
import linegraph in singlegradeinfo
da4cc55 
please
@TatvikReddy
fixing errors
887987a 
doesn't work, just intermediatory changes
@sparklingwter
line graph shows up in blue, toggle button ok, needs to parse correct…
3aae660 
… data.
@TatvikReddy
update for line graph with some additional changes
e17bf9b 
refactor: update search option handling and improve async behavior in filters and search bar
@TatvikReddy
line graph button toggle works
12cbc85
@TyHil
format
c96f1e5
@TyHil
Merge branch 'develop' into 312-feature-request-display-a-line-graph-…
0b5ef73 
…of-gpa-over-time
@TyHil
revert removed comments
6206a6a
@TyHil
revert changes causing warning
434b189 
MUI: You have provided an out-of-range value `undefined` for the select component.
Consider providing a value that matches one of the available options or ''.
The available values are ``, `4.5`, `4`, `3.5`, `3`, `2.5`, `2`, `1.5`, `1`, `0.5`.
@TyHil
format
47955d1
@TyHil
clean up line graph
774b0b4
@TyHil
add to compare
214cea4
@TyHil
format
7bbb72d
@sparklingwter sparklingwter linked an issue Feb 21, 2025 that may be closed by this pull request
[Feature Request] Display a line graph of GPA over time #312
Open
@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 3:58pm

@AbhiramTadepalli
Copy link
Contributor

Wooowwwww!!!

@AbhiramTadepalli
Copy link
Contributor

Great job getting it this far y'all!

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Feb 22, 2025 •
edited by TyHil
Loading

Feedback:

  1. Can we change the animation when you toggle it? I notice that for a prof with only 1 data point (CS 1200, Ranran Feng) the line floats up and then disappears. If possible, I'd like the animation to be the line connecting the points from L->R
  2. Okay see if you can reproduce this: there's something wonky going on when you (a) add 2 results to compare (b) search for a diff course, add that to compare, (c) select the recent filter (d) remove the course you just added to compare. The bar graph like freaks out. The order of these steps might vary
  3. I'm in dark mode rn. I can't rly see the line in the LHS. RHS is a little better but still not all that clear. Maybe the cross-lines can be less white?
  4. I like how the line graph doesn't when you do the semester filter!
  5. May I request a tooltip on the toggle 😏
  6. Are we fine with "# of Students" vs "GPA Trend" as the graph labels for bar and line, respectively?
  7. For this, select overall and cs 4459. In compare, 4459 only has 1 data point, but you can barely see it. What should we do?
  8. I might go to hell for asking this, but dyt it's possible to fade out the other lines a little when I am hovering over one card in the table?

@TyHil
Copy link
Member

TyHil commented Feb 22, 2025 •
edited
Loading

  1. I'll disable animations if there's only one point. L->R not working with line graph on apex charts
  2. how do you find this stuff?? i couldn't reproduce, @sparklingwter @TatvikReddy will y'all try or @AbhiramTadepalli will you be more specific
  3. what color are we changing the star rating to be? we can match that
  4. 👍
  5. @sparklingwter @TatvikReddy will y'all do the tooltip
  6. Maybe "# of Students per Letter Grade" vs "GPA Trend"? Thoughts @sparklingwter @TatvikReddy
  7. You can hover over the legend, other than that not much to do. If someone actually makes it to using compare and switching the graph, I bet they can figure it out
  8. Straight to hell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiramTadepalli AbhiramTadepalli Awaiting requested review from AbhiramTadepalli AbhiramTadepalli is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Display a line graph of GPA over time
4 participants
@sparklingwter @AbhiramTadepalli @TyHil @TatvikReddy