Write PIDFile inside /var/run/usbguard directory

Author: Justin Spencer

src/Daemon/main.cpp

@@ -39,7 +39,7 @@
 #endif
 
 #ifndef USBGUARD_PID_FILE
-  #define USBGUARD_PID_FILE "/var/run/usbguard.pid"
+  #define USBGUARD_PID_FILE "/var/run/usbguard/usbguard.pid"
 #endif
 
 using namespace usbguard;

src/Tests/LDAP/Sanity/ldap-nsswitch.sh

@@ -91,7 +91,7 @@ sudo -n cp "$ldap_path" /etc/usbguard/usbguard-ldap.conf
 
 COUNTER="0"
 declare -A BAD
-PIDFILE="/var/run/usbguard.pid"
+PIDFILE="/var/run/usbguard/usbguard.pid"
 
 function grep_and_fail ()
 {

src/Tests/LDAP/UseCase/ldap-test-1.sh

@@ -89,7 +89,7 @@ sudo -n cat "$ldap_path"
 
 sudo -n cp "$ldap_path" /etc/usbguard/usbguard-ldap.conf
 
-PIDFILE="/var/run/usbguard.pid"
+PIDFILE="/var/run/usbguard/usbguard.pid"
 
 ${LDAP_UTIL} delete && true
 ${LDAP_UTIL} setup

src/Tests/LDAP/UseCase/ldap-test-2.sh

@@ -89,7 +89,7 @@ sudo -n cat "$ldap_path"
 
 sudo -n cp "$ldap_path" /etc/usbguard/usbguard-ldap.conf
 
-PIDFILE="/var/run/usbguard.pid"
+PIDFILE="/var/run/usbguard/usbguard.pid"
 
 ${LDAP_UTIL} delete && true
 ${LDAP_UTIL} setup

src/Tests/LDAP/UseCase/ldap-test-3.sh

@@ -89,7 +89,7 @@ sudo -n cat "$ldap_path"
 
 sudo -n cp "$ldap_path" /etc/usbguard/usbguard-ldap.conf
 
-PIDFILE="/var/run/usbguard.pid"
+PIDFILE="/var/run/usbguard/usbguard.pid"
 
 ${LDAP_UTIL} delete && true
 # ${LDAP_UTIL} setup

src/Tests/LDAP/UseCase/ldap-test-4.sh

@@ -89,7 +89,7 @@ sudo -n cat "$ldap_path"
 
 sudo -n cp "$ldap_path" /etc/usbguard/usbguard-ldap.conf
 
-PIDFILE="/var/run/usbguard.pid"
+PIDFILE="/var/run/usbguard/usbguard.pid"
 
 # ${LDAP_UTIL} delete && true
 # ${LDAP_UTIL} setup

src/Tests/LDAP/UseCase/ldap-test-5.sh

@@ -141,7 +141,7 @@ sudo -n cat "$ldap_path"
 
 sudo -n cp "$ldap_path" /etc/usbguard/usbguard-ldap.conf
 
-PIDFILE="/var/run/usbguard.pid"
+PIDFILE="/var/run/usbguard/usbguard.pid"
 
 ${LDAP_UTIL} delete && true
 ${LDAP_UTIL} setup

src/Tests/UseCase/004_daemonize.sh

@@ -26,7 +26,7 @@ source "${USBGUARD_TESTLIB_BASH}" || exit 129
 export USBGUARD_TESTLIB_TMPDIR="$(mktemp -d --tmpdir usbguard-test.XXXXXX)"
 
 export config_path="${USBGUARD_TESTLIB_TMPDIR}/daemon.conf"
-export pidfile_path="${USBGUARD_TESTLIB_TMPDIR}/usbguard.pid"
+export pidfile_path="${USBGUARD_TESTLIB_TMPDIR}/usbguard/usbguard.pid"
 export logfile="${USBGUARD_TESTLIB_TMPDIR}/daemon.log"
 
 function test_cli_daemonize()

usbguard.service.in

@@ -12,19 +12,20 @@ IPAddressDeny=any
 LockPersonality=yes
 MemoryDenyWriteExecute=yes
 NoNewPrivileges=yes
-PIDFile=/run/usbguard.pid
+PIDFile=/run/usbguard/usbguard.pid
 PrivateDevices=yes
 PrivateTmp=yes
 ProtectControlGroups=yes
 ProtectHome=yes
 ProtectKernelModules=yes
 ProtectSystem=yes
 ReadOnlyPaths=-/
-ReadWritePaths=-/dev/shm -%localstatedir%/log/usbguard -/tmp -%sysconfdir%/usbguard/ -/var/run
+ReadWritePaths=-/dev/shm -%localstatedir%/log/usbguard -/tmp -%sysconfdir%/usbguard/ -/var/run/usbguard
 Restart=on-failure
 RestrictAddressFamilies=AF_UNIX AF_NETLINK
 RestrictNamespaces=yes
 RestrictRealtime=yes
+RuntimeDirectory=usbguard
 SystemCallArchitectures=native
 SystemCallFilter=@system-service
 Type=forking