Skip to content

When homepage is set to default, banner size filter throws error #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexdryden opened this issue Jun 25, 2021 · 1 comment
Open

When homepage is set to default, banner size filter throws error #28

alexdryden opened this issue Jun 25, 2021 · 1 comment
Milestone
Spring 2022

Comments

@alexdryden
Copy link
Contributor

The default setting for homepage is "First page in navigation". If this is set then the filter for the banner size that checks to see if this is the homepage throws an error.
@alexdryden
Copy link
Contributor Author

alexdryden commented Jul 23, 2021 •
edited
Loading

Prevented the error in commit 97d8315 , but this hotfix only prevents the error. Need to set $homepageSlug to the first page in the nav tree if no homepage is set, which is the default homepage when none is set.

@alexdryden alexdryden pinned this issue Mar 21, 2022
@alexdryden alexdryden added this to the Spring 2022 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spring 2022
Development

No branches or pull requests
1 participant
@alexdryden