Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Routing Rules don't apply Launch Args #80

Closed
nathanbabcock opened this issue Nov 2, 2023 · 1 comment
Closed

Auto Routing Rules don't apply Launch Args #80

nathanbabcock opened this issue Nov 2, 2023 · 1 comment
Milestone

Comments

@nathanbabcock
Copy link

First off, thank you for the great program, it is designed so much nicer than other apps like it. πŸ‘

Here's my understanding of the issue β€” in AutoRulesCheck.cs, the browser is started with this command:

Process.Start(x.ExePath, link);

It's missing the LaunchArgs part that is included elsewhere, such as BrowsersList.xaml.cs, there's some extra logic to include the LaunchArgs and apply them to the command:

Process.Start(browser.ExePath, Link + " " + browser.LaunchArgs);

For reference, my use case is this: I have a different Github account for my work, and a separate Chrome profile where I'm logged into my work Github. But when I click PR links in Slack, it randomly opens in either my default profile or the work profile (whichever one I most recently opened a tab in).

@U-C-S
Copy link
Owner

U-C-S commented Nov 10, 2023

Yes, I will release a new version soon to add this. Thanks for me making aware of this.

@U-C-S U-C-S closed this as completed in 700eaf0 Nov 11, 2023
@U-C-S U-C-S added this to the v0.9 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants