Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity Cave Incompability #18

Open
rerun4842 opened this issue Dec 11, 2024 · 7 comments
Open

Infinity Cave Incompability #18

rerun4842 opened this issue Dec 11, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@rerun4842
Copy link

Describe the bug

When using both mods, mobs from "more_mobs" like zombies are conflicting with mobs from Infinity Cave, but mobs not covered by "more_mobs" work just as expected

Steps to reproduce

  1. Spawn a legendary mob from infinity cave using the debug menu
  2. The stats of the mob get instantly modified, on mobs covered by "more_mobs" while stuff like slimes work and ravagers work just as expected

Expected behavior

Mobs from "more_mobs" don't affect the Infinity Cave mobs by debuffing them

Additional context

1.21.3 Fabric Latest version of both mods, latest fabric API

@rerun4842 rerun4842 added the bug Something isn't working label Dec 11, 2024
@rerun4842
Copy link
Author

An option is to allow more_mobs to only spawn above specific y level

@Tschipcraft Tschipcraft self-assigned this Dec 11, 2024
@Tschipcraft
Copy link
Owner

Thank you for the report. By stats, I assume you mean armor, tools and weapons?

@rerun4842
Copy link
Author

Stuff Like HP, speed etc.

@Tschipcraft
Copy link
Owner

Hm, More Mobs itself does not change stats. However, it could be that the buffs are tied to the armor the mobs are wearing, which could be overridden when a custom head is given.
I had a check in place to prevent this, but I just noticed that it's broken for 1.21.3. This will be fixed in the next release

@rerun4842
Copy link
Author

I'm sorry for asking this but when could I except the next release?

@Tschipcraft
Copy link
Owner

Tschipcraft commented Dec 11, 2024

I usually don't push updates for single fixes like this one, so I don't want to give an ETA.
If you need a fix asap, navigate to data\more_mobs\function\general\parse_heads\parse.mcfunction inside the .jar and replace

# Exclusion for already filled head slots
execute as @s[tag=!ts.mm.parsed] as @s[nbt={ArmorItems:[{},{},{},{Count:1b}]}] run tag @s add ts.mm.parsed

with

# Exclusion for already filled head slots
execute as @s[tag=!ts.mm.parsed] as @s[nbt={ArmorItems:[{},{},{},{count:1}]}] run tag @s add ts.mm.parsed

This should be enough for the check to work in 1.21.3 (it will still be broken in 1.20.6 for anyone else reading this)

@rerun4842
Copy link
Author

I'll test it right away and let you know! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants