From c96a8ebf77308e7f63b01fca505225e9584dedff Mon Sep 17 00:00:00 2001 From: Aileen Nowak Date: Mon, 30 Apr 2018 11:27:47 +0800 Subject: [PATCH] fix(doctor): skip install dir checks for local installs closes #711 --- .../doctor/checks/install-folder-permissions.js | 4 +++- .../checks/install-folder-permissions-spec.js | 13 +++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/commands/doctor/checks/install-folder-permissions.js b/lib/commands/doctor/checks/install-folder-permissions.js index 6ef56e5db..9f736697c 100644 --- a/lib/commands/doctor/checks/install-folder-permissions.js +++ b/lib/commands/doctor/checks/install-folder-permissions.js @@ -16,7 +16,9 @@ function installFolderPermissions(ctx) { task: taskTitle })); }).then(() => { - if (ctx.local || !ctx.system.platform.linux || (ctx.argv && ctx.argv['setup-linux-user'] === false)) { + const isLocal = ctx.local || (ctx.instance && ctx.instance.process.name === 'local'); + + if (isLocal || !ctx.system.platform.linux || (ctx.argv && ctx.argv['setup-linux-user'] === false)) { return Promise.resolve(); } diff --git a/test/unit/commands/doctor/checks/install-folder-permissions-spec.js b/test/unit/commands/doctor/checks/install-folder-permissions-spec.js index 538bb1563..cbfe1add6 100644 --- a/test/unit/commands/doctor/checks/install-folder-permissions-spec.js +++ b/test/unit/commands/doctor/checks/install-folder-permissions-spec.js @@ -42,6 +42,19 @@ describe('Unit: Doctor Checks > installFolderPermissions', function () { }); }); + it('skips checking parent folder permissions if local process manager is used', function () { + const accessStub = sandbox.stub(fs, 'access').resolves(); + const checkDirectoryStub = sandbox.stub().resolves(); + const installFolderPermissions = proxyquire(modulePath, { + './check-directory': checkDirectoryStub + }).task; + + return installFolderPermissions({instance: {process: {name: 'local'}}}).then(() => { + expect(accessStub.calledOnce).to.be.true; + expect(checkDirectoryStub.called).to.be.false; + }); + }); + it('skips checking parent folder permissions if os is not linux', function () { const accessStub = sandbox.stub(fs, 'access').resolves(); const checkDirectoryStub = sandbox.stub().resolves();