Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): query process managers in dev & prod if running not set #607

Merged
merged 1 commit into from
Feb 3, 2018

Conversation

acburdine
Copy link
Member

closes #463

  • query each process manager if running is not set in cli config

@acburdine acburdine requested review from kirrg001 and aileen February 2, 2018 10:48
@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage increased (+0.009%) to 98.597% when pulling 2c5f084 on acburdine:fix/is-running into dce09e1 on TryGhost:master.

@kirrg001 kirrg001 self-assigned this Feb 3, 2018
@kirrg001
Copy link
Contributor

kirrg001 commented Feb 3, 2018

Just leaving this here.


You have a dev and prod config file. Both use the local process manager. You start your development blog (ghost start). Then you loose the information that your instance is running in your .ghost-cli file. You do ghost ls and it would show that production is running. This could be solved by writing the PID including the env information?


You install a production blog on linux. Then you run cp config.production.json config.development.json. No modifications. You stop your blog. Your run ghost start and you will see running (development). Not sure how that is possible.

Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to self merge after the fix for the second case 👍 We will ignore the first case for now, because it is not critical.

closes TryGhost#463
- query each process manager if running is not set in cli config
@acburdine acburdine merged commit c6b8b40 into TryGhost:master Feb 3, 2018
@acburdine acburdine deleted the fix/is-running branch February 3, 2018 11:04
acburdine added a commit to acburdine/Ghost-CLI that referenced this pull request Feb 3, 2018
acburdine added a commit that referenced this pull request Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ghost run be responsible for outputting running environment
3 participants