fix(doctor): Folder permissions check considers setuid, setgid, and sticky bits #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icky bits Closes TryGhost#724 - Prefixed the folder permissions check help command chmod paramter with "00" to clear the setuid, setgid, and sticky bits - Updated the unit tests for folder permissions to coincide with aforementioned change
| @@ -18,7 +18,7 @@ module.exports = function checkPermissions(type, task) { | |||
| }, | |||
| folder: { | |||
| command: 'find ./ -type d ! -perm 775 ! -perm 755', | |||
| help: `Run ${chalk.green('sudo find ./ -type d -exec chmod 775 {} \\;')} and try again.` | |||
| help: `Run ${chalk.green('sudo find ./ -type d -exec chmod 00775 {} \\;')} and try again.` | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I'm thinking about if we need to add the leading zeros to the files help command as well. According to the manual, the sticky bit is cleared if the user executing the command isn't the owner or isn't in the group (of course T+C apply). Given that and the fact the user shouldn't be the owner (because Ghost should own the content folder), it seems like the owner check + the chmod command should cause the system to fix it 🤔 |
|
I played around with it a bit the other day and special permissions on files did not seem to affect the installation - probably because the system fixed it as you said. |
acburdine
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(doctor): Folder permissions check considers setuid, setgid, and sticky bits
closes #724