Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance running detection should be a bit smarter. #207

Closed
acburdine opened this issue Jun 12, 2017 · 0 comments · Fixed by #251
Closed

Instance running detection should be a bit smarter. #207

acburdine opened this issue Jun 12, 2017 · 0 comments · Fixed by #251
Assignees
@acburdine
Labels
bug enhancement
Milestone
1.0.0-rc.1

Comments

@acburdine
Copy link
Member

Currently the way Ghost-CLI determines whether an instance of ghost is currently running is by looking at the running value in the .ghost-cli json. It works for the most part, however this can be unreliable if the system running Ghost has to restart and Ghost doesn't get a chance to shut down correctly.

Two things should probably happen:

  1. Addition of a isRunning method to the Process Manager base class, used to check if the instance is still running
  2. Update the logic of ghost start/ghost stop/ghost ls to call that particular process manager method if the running property is set in the cli config file, and if the process manager returns false, unset the property from the CLI.
@acburdine acburdine added this to the 1.0.0-beta.1 milestone Jun 12, 2017
@acburdine acburdine self-assigned this Jun 12, 2017
This was referenced Jun 17, 2017
Closed
Closed
Closed
@acburdine acburdine mentioned this issue Jun 27, 2017
Closed
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 29, 2017
@acburdine
feat(process): update running check to call process manager
620ab22 
closes TryGhost#207
- updates the running check to make sure the process is actually running
- adds a method to the process manager class (required to implement)
@acburdine acburdine mentioned this issue Jun 29, 2017
Merged
acburdine added a commit that referenced this issue Jun 29, 2017
@acburdine
feat(process): update running check to call process manager
2f01ad0 
closes #207
- updates the running check to make sure the process is actually running
- adds a method to the process manager class (required to implement)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acburdine acburdine

Labels
bug enhancement
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

feat(process): update running check to call process manager acburdine/Ghost-CLI
1 participant
@acburdine