perf: lazily require modules in commands

refs #428
- defer requiring modules in commands to as late as possible

lib/commands/buster.js

@@ -1,9 +1,10 @@
 'use strict';
 const Command = require('../command');
-const yarn = require('../utils/yarn');
 
 class BusterCommand extends Command {
     run() {
+        const yarn = require('../utils/yarn');
+
         return this.ui.run(yarn(['cache', 'clean']), 'Clearing yarn cache');
     }
 }

lib/commands/config/index.js

@@ -1,12 +1,8 @@
 'use strict';
 const url           = require('url');
-const validator     = require('validator');
-const isFunction    = require('lodash/isFunction');
-const Promise       = require('bluebird');
 
 const Command           = require('../../command');
 const advancedOptions   = require('./advanced');
-const errors            = require('../../errors');
 
 class ConfigCommand extends Command {
     constructor(ui, system) {
@@ -16,6 +12,10 @@ class ConfigCommand extends Command {
     }
 
     handleAdvancedOptions(argv) {
+        const errors = require('../../errors');
+        const Promise = require('bluebird');
+        const isFunction = require('lodash/isFunction');
+
         return Promise.each(Object.keys(advancedOptions), (key) => {
             let option = advancedOptions[key];
             let value = argv[key];
@@ -70,6 +70,7 @@ class ConfigCommand extends Command {
     }
 
     getConfigPrompts(argv) {
+        const validator     = require('validator');
         let prompts = [];
 
         if (!argv.url) {

lib/commands/install.js

@@ -1,19 +1,7 @@
 'use strict';
-const fs = require('fs-extra');
 const path = require('path');
-const every = require('lodash/every');
-const Promise = require('bluebird');
 const Command = require('../command');
 const symlinkSync = require('symlink-or-copy').sync;
-
-// Utils
-const resolveVersion = require('../utils/resolve-version');
-const errors = require('../errors');
-
-// Tasks/Commands
-const installChecks = require('./doctor/checks/install');
-const ensureStructure = require('../tasks/ensure-structure');
-const yarnInstall = require('../tasks/yarn-install');
 const SetupCommand = require('./setup');
 
 class InstallCommand extends Command {
@@ -23,6 +11,13 @@ class InstallCommand extends Command {
     }
 
     run(argv) {
+        const fs = require('fs-extra');
+        const every = require('lodash/every');
+        const errors = require('../errors');
+        const yarnInstall = require('../tasks/yarn-install');
+        const installChecks = require('./doctor/checks/install');
+        const ensureStructure = require('../tasks/ensure-structure');
+
         // Dir was specified, so we make sure it exists and chdir into it.
         if (argv.dir) {
             let dir = path.resolve(argv.dir);
@@ -91,6 +86,8 @@ class InstallCommand extends Command {
     }
 
     version(ctx) {
+        const resolveVersion = require('../utils/resolve-version');
+
         return resolveVersion(ctx.version).then((version) => {
             ctx.version = version;
             ctx.installPath = path.join(process.cwd(), 'versions', version);

lib/commands/log.js

@@ -1,17 +1,16 @@
 'use strict';
-const fs = require('fs-extra');
-const path = require('path');
-const includes = require('lodash/includes');
-const lastLines = require('read-last-lines');
-const Tail = require('tail').Tail;
-const Promise = require('bluebird');
-const PrettyStream = require('ghost-ignition/lib/logging/PrettyStream');
-
-const errors = require('../errors');
 const Command = require('../command');
 
 class LogCommand extends Command {
     run(argv) {
+        const fs = require('fs');
+        const path = require('path');
+        const includes = require('lodash/includes');
+        const lastLines = require('read-last-lines');
+        const PrettyStream = require('ghost-ignition/lib/logging/PrettyStream');
+
+        const errors = require('../errors');
+
         if (!argv.name) {
             Command.checkValidInstall('log');
         }
@@ -64,6 +63,8 @@ class LogCommand extends Command {
             lines.trim().split('\n').forEach(line => prettyStream.write(line));
 
             if (argv.follow) {
+                const Tail = require('tail').Tail;
+
                 let tail = new Tail(logFileName);
                 tail.on('line', (line) => prettyStream.write(line, 'utf8'));
             }

lib/commands/ls.js

@@ -1,9 +1,10 @@
 'use strict';
-const chalk = require('chalk');
 const Command = require('../command');
 
 class LsCommand extends Command {
     run() {
+        const chalk = require('chalk');
+
         let instances = this.system.getAllInstances();
         let rows = instances.map((instance) => {
             let summary = instance.summary();

lib/commands/run.js

@@ -1,12 +1,12 @@
 'use strict';
-const path = require('path');
 const spawn = require('child_process').spawn;
-const errors = require('../errors');
 const Command = require('../command');
-const shouldUseGhostUser = require('../utils/use-ghost-user');
 
 class RunCommand extends Command {
     run() {
+        const path = require('path');
+        const shouldUseGhostUser = require('../utils/use-ghost-user');
+
         // If the user is running this command directly, output a little note
         // telling them they're likely looking for `ghost start`
         if (process.stdin.isTTY) {
@@ -28,6 +28,8 @@ class RunCommand extends Command {
     }
 
     useGhostUser(instance) {
+        const errors = require('../errors');
+
         this.ui.log('Running sudo command: node current/index.js', 'gray');
 
         this.child = spawn('sudo', `-E -u ghost ${process.execPath} current/index.js`.split(' '), {

lib/commands/setup.js

@@ -1,19 +1,13 @@
 'use strict';
-const os             = require('os');
-const url            = require('url');
-const path           = require('path');
-const get            = require('lodash/get');
-const omit           = require('lodash/omit');
-const includes       = require('lodash/includes');
-
 const Command        = require('../command');
-const migrate        = require('../tasks/migrate');
-const linux          = require('../tasks/linux');
 const StartCommand   = require('./start');
 const ConfigCommand  = require('./config');
 
 class SetupCommand extends Command {
     static configureOptions(commandName, yargs, extensions, onlyOptions) {
+        const get = require('lodash/get');
+        const omit = require('lodash/omit');
+
         extensions.forEach((extension) => {
             let options = get(extension, 'config.options.setup', false);
             if (!options) {
@@ -44,6 +38,15 @@ class SetupCommand extends Command {
     }
 
     run(argv) {
+        const os = require('os');
+        const url  = require('url');
+        const path = require('path');
+        const includes = require('lodash/includes');
+
+        const linux = require('../tasks/linux');
+        const migrate = require('../tasks/migrate');
+
+
         if (argv.local) {
             argv.url = argv.url || 'http://localhost:2368/';
             argv.pname = argv.pname || 'ghost-local';

lib/commands/start.js

@@ -1,13 +1,11 @@
 'use strict';
-const get = require('lodash/get');
-const omit = require('lodash/omit');
-
 const Command = require('../command');
-const startupChecks = require('./doctor/checks/startup');
-const ProcessManager = require('../process-manager');
 
 class StartCommand extends Command {
     static configureOptions(commandName, yargs, extensions) {
+        const get = require('lodash/get');
+        const omit = require('lodash/omit');
+
         extensions.forEach((extension) => {
             let options = get(extension, 'config.options.start', false);
             if (!options) {
@@ -21,6 +19,9 @@ class StartCommand extends Command {
     }
 
     run(argv) {
+        const ProcessManager = require('../process-manager');
+        const startupChecks = require('./doctor/checks/startup');
+
         let instance = this.system.getInstance();
         const runOptions = {quiet: argv.quiet};
 

lib/commands/stop.js

@@ -1,14 +1,11 @@
 'use strict';
-const get = require('lodash/get');
-const omit = require('lodash/omit');
-const Promise = require('bluebird');
-
-const errors = require('../errors');
 const Command = require('../command');
-const ProcessManager = require('../process-manager');
 
 class StopCommand extends Command {
     static configureOptions(commandName, yargs, extensions) {
+        const get = require('lodash/get');
+        const omit = require('lodash/omit');
+
         extensions.forEach((extension) => {
             let options = get(extension, 'config.options.start', false);
             if (!options) {
@@ -22,6 +19,9 @@ class StopCommand extends Command {
     }
 
     run(argv) {
+        const errors = require('../errors');
+        const ProcessManager = require('../process-manager');
+
         const runOptions = {quiet: argv.quiet};
 
         if (argv.all) {
@@ -58,6 +58,8 @@ class StopCommand extends Command {
     }
 
     stopAll() {
+        const Promise = require('bluebird');
+
         let instances = this.system.getAllInstances(true);
         let cwd = process.cwd();
 

lib/commands/uninstall.js

@@ -1,13 +1,13 @@
 'use strict';
-const fs = require('fs-extra');
-const os = require('os');
-const path = require('path');
-
-const StopCommand = require('./stop');
 const Command = require('../command');
 
 class UninstallCommand extends Command {
     run(argv) {
+        const fs = require('fs-extra');
+        const os = require('os');
+        const path = require('path');
+        const StopCommand = require('./stop');
+
         let prompt;
 
         if (!argv.force && argv.prompt) {

lib/commands/update.js

@@ -1,24 +1,21 @@
 'use strict';
 const fs = require('fs-extra');
 const path = require('path');
-const chalk = require('chalk');
-const semver = require('semver');
-const symlinkSync = require('symlink-or-copy').sync;
 
 // Utils
 const errors = require('../errors');
 const Command = require('../command');
-const resolveVersion = require('../utils/resolve-version');
-
-// Tasks/Commands
-// TODO: update checks
-const migrate = require('../tasks/migrate');
-const yarnInstall = require('../tasks/yarn-install');
-const StopCommand = require('./stop');
-const StartCommand = require('./start');
 
 class UpdateCommand extends Command {
     run(argv) {
+        const chalk = require('chalk');
+        const semver = require('semver');
+
+        const migrate = require('../tasks/migrate');
+        const yarnInstall = require('../tasks/yarn-install');
+        const StopCommand = require('./stop');
+        const StartCommand = require('./start');
+
         let instance = this.system.getInstance();
 
         // If installed with a version < 1.0
@@ -107,6 +104,8 @@ class UpdateCommand extends Command {
     }
 
     version(context) {
+        const resolveVersion = require('../utils/resolve-version');
+
         if (context.rollback) {
             return Promise.resolve(true);
         }
@@ -125,6 +124,8 @@ class UpdateCommand extends Command {
     }
 
     link(context) {
+        const symlinkSync = require('symlink-or-copy').sync;
+
         fs.removeSync(path.join(process.cwd(), 'current'));
         symlinkSync(context.installPath, path.join(process.cwd(), 'current'));
 

lib/commands/version.js

@@ -1,10 +1,11 @@
 'use strict';
-const os = require('os');
-const chalk = require('chalk');
 const Command = require('../command');
 
 class VersionCommand extends Command {
     run() {
+        const os = require('os');
+        const chalk = require('chalk');
+
         let cliVersion = this.system.cliVersion;
         this.ui.log(`Ghost-CLI version: ${chalk.cyan(cliVersion)}`);