From 2e69a1ad3566bf9dccf9a6eb743d76dbc2e7c3f4 Mon Sep 17 00:00:00 2001 From: alvarosabu Date: Thu, 17 Aug 2023 19:32:38 +0200 Subject: [PATCH 1/2] fix: useGLTF return types --- playground/components.d.ts | 2 ++ playground/src/components/AkuAku.vue | 14 ++++++++++++++ playground/src/pages/UseGLTFDemo.vue | 26 ++++++++++++++++++++++++++ playground/src/router.ts | 5 +++++ src/core/loaders/useGLTF/component.vue | 6 ++++-- src/core/loaders/useGLTF/index.ts | 6 +++--- 6 files changed, 54 insertions(+), 5 deletions(-) create mode 100644 playground/src/components/AkuAku.vue create mode 100644 playground/src/pages/UseGLTFDemo.vue diff --git a/playground/components.d.ts b/playground/components.d.ts index 45ebd25d..c1cd4fbe 100644 --- a/playground/components.d.ts +++ b/playground/components.d.ts @@ -7,9 +7,11 @@ export {} declare module 'vue' { export interface GlobalComponents { + AkuAku: typeof import('./src/components/AkuAku.vue')['default'] BackdropDemo: typeof import('./src/components/BackdropDemo.vue')['default'] ContactShadowsDemo: typeof import('./src/components/ContactShadowsDemo.vue')['default'] EnvironmentDemo: typeof import('./src/components/EnvironmentDemo.vue')['default'] + GlassMaterialDemo: typeof import('./src/components/GlassMaterialDemo.vue')['default'] Gltf: typeof import('./src/components/gltf/index.vue')['default'] LeviosoDemo: typeof import('./src/components/LeviosoDemo.vue')['default'] MapControlsDemo: typeof import('./src/components/MapControlsDemo.vue')['default'] diff --git a/playground/src/components/AkuAku.vue b/playground/src/components/AkuAku.vue new file mode 100644 index 00000000..26583332 --- /dev/null +++ b/playground/src/components/AkuAku.vue @@ -0,0 +1,14 @@ + + + diff --git a/playground/src/pages/UseGLTFDemo.vue b/playground/src/pages/UseGLTFDemo.vue new file mode 100644 index 00000000..a4e4232b --- /dev/null +++ b/playground/src/pages/UseGLTFDemo.vue @@ -0,0 +1,26 @@ + + + diff --git a/playground/src/router.ts b/playground/src/router.ts index 748261dc..07a16908 100644 --- a/playground/src/router.ts +++ b/playground/src/router.ts @@ -76,6 +76,11 @@ const routes = [ name: 'MouseParallax', component: () => import('./pages/MouseParallaxDemo.vue'), }, + { + path: '/loaders/use-gltf', + name: 'useGLTF', + component: () => import('./pages/UseGLTFDemo.vue'), + } ] export const router = createRouter({ diff --git a/src/core/loaders/useGLTF/component.vue b/src/core/loaders/useGLTF/component.vue index f60cd530..4479e2f5 100644 --- a/src/core/loaders/useGLTF/component.vue +++ b/src/core/loaders/useGLTF/component.vue @@ -52,8 +52,10 @@ defineExpose({ value: modelRef, }) -const { scene:model } = await useGLTF(props.path as string, { draco: props.draco, decoderPath: props.decoderPath }) - +const { scene: model } = await useGLTF(props.path as string, { + draco: props.draco, + decoderPath: props.decoderPath, +})