Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+number cannot select channel groups on Linux/Windows #229

Closed
MKimiSH opened this issue May 23, 2024 · 1 comment
Closed

Ctrl+number cannot select channel groups on Linux/Windows #229

MKimiSH opened this issue May 23, 2024 · 1 comment

Comments

@MKimiSH
Copy link
Contributor

MKimiSH commented May 23, 2024

I believe the cause is the !(modifiers & SYSTEM_COMMAND_MOD) in the following line:

if (key >= GLFW_KEY_0 && key <= GLFW_KEY_9 && !(modifiers & SYSTEM_COMMAND_MOD)) {
. On Windows and Linux, this is the same as Ctrl, so it blocked the Ctrl+number key combination. This seems related with introducing Ctrl/Cmd+0 and Ctrl/Cmd+9 for setting image transforms.

I think the new Ctrl+0/9 behavior is more useful than selecting the 9th or 10th channel group. Meanwhile, we can perhaps keep Ctrl+[1-8]? It introduces a bit of inconsistency though.

@Tom94
Copy link
Owner

Tom94 commented May 23, 2024

Oops, good catch! Thanks & sorry for the accidental breakage. Just pushed a fix that makes Ctrl+1-8 work (I agree 9 and 0 aren't necessary here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants