Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop react-native-device-info for react-native-safe-area-context[FEATURE] #140

Closed
2 tasks done
itsramiel opened this issue Jun 7, 2022 · 0 comments · Fixed by #154
Closed
2 tasks done

Drop react-native-device-info for react-native-safe-area-context[FEATURE] #140

itsramiel opened this issue Jun 7, 2022 · 0 comments · Fixed by #154

Comments

@itsramiel
Copy link

Is your feature request related to a problem? Please describe.
I am trying out the library with expo since it says support expo>=41, but react-native-device-info is not supported by expo which makes this library not accessible for expo user unless using a custom development client.

It is prevents most expo users from using this library, me being one of them, especially since you are only using hasNotch method.

Describe the solution you'd like
Use react-native-safe-area-context for the following reasons:

  • supported by expo
  • it gives you the exact notch height instead of whether there is a notch or not and setting a random value of 50 for the notch height as I can see in the source code

Describe alternatives you've considered
Use a custom development client to install react-native-device-info, but it is really not worth it the work into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant