Skip to content

Fix: Adding missing Arabic and Ukrainian in various JSON #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix: Adding missing Arabic and Ukrainian in various JSON #2717

wants to merge 4 commits into from

Conversation

Polypheides
Copy link
Contributor

@Polypheides Polypheides commented Mar 21, 2025 •
edited
Loading

Here is the requested Ukrainian addition together with a Missing? Arabic entry in Patch104pZH/ModBundleOptionalLanguageItems.json

Ukrainian will not build yet unless added to the gametextcompiler this will be fixed later

My changes for gametextcompiler
gametextcompiler code Ukrainian UA
gametextcompiler code Ukrainian UK
gametextcompiler code Swedish SV and Ukrainian UK
gametextcompiler code Swedish SV, Ukrainian UK, Azerbaijani AZ Turkish TR
gametextcompiler code Now adds almost all the languages in the world

I have also added _comments for each community-made language

Reason for the Swedish entries seen in the files changed is because Ukrainian entries comes after Swedish alphabetically in the JSON and that the Swedish PR #2715 is not merged yet.

@Polypheides
Adding SE entries in .json
aab3310 
Update ModBundleOptionalLanguageItems.json

adding swedish entries in .json
@Polypheides
Merge branch 'TheSuperHackers:main' into Adding-SE-entries-in-json
e895277
@Polypheides Polypheides changed the title Adding _comments, Ukrainian entries in various json and a missing Arabic entry Fix: Adding missing Arabic, Ukrainian and _comment in various JSON Mar 25, 2025
@Polypheides
Updating JSON with missing entries
fc89129 
Update ModBundleFullPacks.json

Adding _comment and a "missing Arabic option?"

Squashed commit of the following:

commit d9b0c10
Author: Polypheides <rivaljohansson@gmail.com>
Date:   Fri Mar 21 20:08:03 2025 +0100

    fix

commit b8c2ddd
Author: Polypheides <rivaljohansson@gmail.com>
Date:   Fri Mar 21 20:01:54 2025 +0100

    Update ModBundleFullPacks.json

commit 6e6c383
Author: Polypheides <rivaljohansson@gmail.com>
Date:   Fri Mar 21 19:56:25 2025 +0100

    Update ModBundleCoreLanguageItems.json

update alphabetic order

Update ModBundleCoreLanguageItems.json

_comment": "This Swedish localization is community-made"

An example comment in JSON

Update ModBundleCoreLanguageItems.json
@Polypheides Polypheides force-pushed the Adding-UK-entries-in-json branch from 047106c to fc89129 Compare March 25, 2025 11:28
@DevGeniusCode DevGeniusCode mentioned this pull request Mar 25, 2025
Open
@DevGeniusCode
Copy link
Collaborator

@Polypheides is this ready to review?

@Polypheides
Copy link
Contributor Author

Polypheides commented Mar 25, 2025 •
edited
Loading

is this ready to review?

All my pull request are always ready for scrutiny.
So yes you may review it but we still miss critical fixes for the changes to work 'gametextcompiler'.

and #2715 comes first in the commit chain that needs reviewing and approval adding Swedish.

my latest iteration of gametextcompiler works with both SV and UK Polypheides/Thyme@95138dc but contains comments in code that we might not want in the 'gametextcompiler' main branch.

@Polypheides Polypheides mentioned this pull request Mar 30, 2025
Open
@Polypheides
Copy link
Contributor Author

Polypheides commented Mar 30, 2025 •
edited
Loading

"I have a commit for this pull request waiting to be pushed, removing _comment. xezon argued against adding comments to these files (#2715). We'll see what he decides."

I think this comment is not necessary here. There already is a wiki page somewhere which could list the original game languages, which then implies which ones are community made.

Here is the wiki page
https://github.com/TheSuperHackers/GeneralsGamePatch/wiki/localization_contribution

@Polypheides Polypheides changed the title Fix: Adding missing Arabic, Ukrainian and _comment in various JSON Fix: Adding missing Arabic, Ukrainian in various JSON Mar 30, 2025
@Polypheides Polypheides changed the title Fix: Adding missing Arabic, Ukrainian in various JSON Fix: Adding missing Arabic and Ukrainian in various JSON Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ukrainian localization is not available in Mod Builder
2 participants
@Polypheides @DevGeniusCode