-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "esc" as a key alias of "escape" #5593
Comments
There may be multiple ways of abbreviating key names, which is why I don't like to abbreviate at all. Run |
It's a shame you wasted any time on this, as running I know this is mentioned in the FAQ, but perhaps this could be advertised more widely in the docs? |
I actually tried running All incarnations of trying to run it ended up with me unknowingly using our work pypi which still has 1.X and so I was getting the old textual demo OR when I tried things like Perhaps a separate request could be ensuring That means I would've run |
That's understandable. Hopefully my mistake is also understandable (given how my keyboard says "esc" and "ctrl"). Out of raw curiosity, what's the downside to this alias (or any alias)? |
Also FWIW happy to make PR for anything I suggest 🤩 |
I wouldn't want the commands to run in their own environment. They could be out of sync with the project.
I don't see much point in maintaining aliases (there could be many, not just escape), when the "no abbreviation" rule of thumb generally makes it clear. It would also lead to code that has keys using different spellings, and confuse beginners. I didn't mean to imply any criticism for getting it wrong. Easy done, but now that you know, you know. |
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
In this case suggesting running |
I spent an embarassing amount of time trying to understand why my
"esc"
binding (orkey_esc
) wasn't working.It took poking at
keys.py
to notice my unfortunate mistake...The text was updated successfully, but these errors were encountered: