Skip to content

Add new chip border radii token #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: production
Choose a base branch
from

Conversation

aweell
Copy link
Collaborator

@aweell aweell commented Mar 12, 2025

Introduces a new "chip" border radius token across multiple design token files. The motivation behind this change is to standardize the styling of chip components in our UI, ensuring consistency and alignment with our design guidelines.

By adding this token, we provide designers and developers with a dedicated value for chip components, making it easier to maintain visual coherence throughout our application. This update also enhances our schema by including "chip" in the required properties for border radii, ensuring that any future components can access this styling property seamlessly.

Overall, this change improves the project by promoting design consistency, enhancing usability for developers, and ensuring our UI components align with modern design standards.

@aweell aweell linked an issue Mar 12, 2025 that may be closed by this pull request
6 tasks
@aweell aweell requested a review from yceballost March 12, 2025 10:39
@AnaMontes11
Copy link
Contributor

Would this open the possibility for eSimFlag chips to have an 8px border radius? @aweell

@aweell
Copy link
Collaborator Author

aweell commented Mar 12, 2025

Yes

@AnaMontes11
Copy link
Contributor

Great, we can include it along with the informative tag.

@aweell
Copy link
Collaborator Author

aweell commented Mar 13, 2025

Great, we can include it along with the informative tag.

It's already included

@aweell aweell marked this pull request as draft March 17, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border radius chips
3 participants