-
Notifications
You must be signed in to change notification settings - Fork 6
Add new chip border radii token #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aweell
wants to merge
7
commits into
production
Choose a base branch
from
aweell-new-border-radius-chip
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
yceballost
approved these changes
Mar 12, 2025
Would this open the possibility for eSimFlag chips to have an 8px border radius? @aweell |
Yes |
Great, we can include it along with the informative tag. |
It's already included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new "chip" border radius token across multiple design token files. The motivation behind this change is to standardize the styling of chip components in our UI, ensuring consistency and alignment with our design guidelines.
By adding this token, we provide designers and developers with a dedicated value for chip components, making it easier to maintain visual coherence throughout our application. This update also enhances our schema by including "chip" in the required properties for border radii, ensuring that any future components can access this styling property seamlessly.
Overall, this change improves the project by promoting design consistency, enhancing usability for developers, and ensuring our UI components align with modern design standards.