Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Fix Unlinked Entries" not functioning, only returns None count #652

Closed
3 tasks done
CyanVoxel opened this issue Dec 21, 2024 · 1 comment · Fixed by #653
Closed
3 tasks done

[Bug]: "Fix Unlinked Entries" not functioning, only returns None count #652

CyanVoxel opened this issue Dec 21, 2024 · 1 comment · Fixed by #653
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Milestone

Comments

@CyanVoxel
Copy link
Member

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

main branch (v9.5.0)

Operating System & Version

macOS 15.1.1

Description

Using the "Fix Unlined Entries" tool only ever returns "None" as the count value, even if there are unlinked entries present in the library.

This seems to stem from this change made to fix_unlinked.py in #528. From what I can tell it seems that set_missing_count() is being passed as a callable function to from_iterable_function and is being called when the done signal inside its CustomRunnable r is emitted - however without any count argument passing to set_missing_count(), resulting in the method's default behavior of setting the count to None.

Expected Behavior

Refreshing the unlinked entries method should return the count of the unlinked entries, and a 0 if none are found. Note that the "None" text currently being shown is not a result of there being no unlinked entries, but rather is an errant None value being displayed as the count.

Steps to Reproduce

  1. Open a TagStudio library

  2. Move or delete a present in the library on disk to create an "unlinked entry"

  3. Go to "Tools -> Fix Unlinked Entries" and click "Refresh All"

  4. Note how the count now always says "Unlinked Entries: None"

  5. Bonus: Repeat the previous steps while omitting step 2, noting the same result

Logs

No response

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended TagStudio: Library Relating to the TagStudio library system Priority: High An important issue requiring attention labels Dec 21, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Dec 21, 2024
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Dec 21, 2024
@SkeleyM
Copy link
Contributor

SkeleyM commented Dec 21, 2024

id like to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants