Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Instant/Convenient Playback for Audio #568

Closed
3 tasks done
AudleStudios opened this issue Oct 30, 2024 · 3 comments
Closed
3 tasks done

[Feature Request]: Instant/Convenient Playback for Audio #568

AudleStudios opened this issue Oct 30, 2024 · 3 comments
Labels
Priority: Low Doesn't require immediate attention Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience

Comments

@AudleStudios
Copy link

AudleStudios commented Oct 30, 2024

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

Description

In any DAW, an audio browser lets you tap a sound to play it instantly. Currently in Tag Studio, you have to open the file manually.

Solution

Adding a play button to each icon, placing it next to the archive option, and turning the play button to a pause button when pressed.

image

(This would probably have to added after built-in audio playback is)

Alternatives

Placing it on the right half of each icon (on-hover)
image

Adding on to the first solution, adding a stop button, which would stop playback, and start the playback from the beginning when play is pressed again.

image

or

image

@AudleStudios AudleStudios added the Type: Enhancement New feature or request label Oct 30, 2024
@CyanVoxel
Copy link
Member

Thank you for the feature request! While TagStudio is far from a DAW, we would like to at least have basic audio playback to aide with file classification and discovery (under the umbrella of audio browser, I suppose).

Currently we're planning on delegating audio playback to the Preview Panel, with #450 being the open issue for it and #529 being the last PR opened for it, however that PR was recently accidentally closed and I believe @VasigaranAndAngel has been prototyping a separate audio player that does not have an open PR at the moment, but adds a playback scrubbing tool over the audio waveform in Preview Panel.

Both of the above in-progress implementations follow the pattern of the Preview Panel being used for playback and in-depth previews of files, which is where I would personally like to keep this sort of functionality. I don't believe that this would be too disruptive to tagging and browsing workflows, and would make both the development of audio playback and the continued development of the thumbnail widgets significantly easier going forward.

If you're satisfied with this approach or have a compelling use case for having audio previews outside of the Preview Panel (that's also in the scope of the program) then I'll be more than happy to keep this request open.

@CyanVoxel CyanVoxel added Type: UI/UX User interface and/or user experience Priority: Low Doesn't require immediate attention labels Nov 4, 2024
@Cool-Game-Dev
Copy link
Contributor

I like the top option the best, no need to make it complicated.

@CyanVoxel
Copy link
Member

CyanVoxel commented Nov 30, 2024

Audio playback for the preview panel added in #576 (formerly #529)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Doesn't require immediate attention Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
None yet
Development

No branches or pull requests

3 participants