Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: option to generate smaller thumbnails for images above a certain size #345

Closed
3 tasks done
BPplays opened this issue Aug 9, 2024 · 2 comments · Fixed by #694
Closed
3 tasks done
Assignees
Labels
Priority: High An important issue requiring attention Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience

Comments

@BPplays
Copy link
Contributor

BPplays commented Aug 9, 2024

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

Description

sometimes large images can take a relatively long time to load

Solution

an option to have TagStudio generate smaller thumbnails for images above a certain size in configurable sizes, formats (e.g. jxl, webp, png, etc) , and quality that are loaded first before the main image would improve responsiveness while navigating images.

also there doesn't seem to be any settings menu at the moment, my opinion on a settings menu for this kinda stuff is that it should default to global settings but be optionally changeable per library too.

Alternatives

some formats support progressive decoding but jxl is the only one i can think of that could act in a similar way but even then i don't think all jxls support progressive decoding.
also I'm not sure if jxl progressive decoding would fix this issue, I'm not sure what makes up the load time for images if it's primarily disc usage or rendering

@BPplays BPplays added the Type: Enhancement New feature or request label Aug 9, 2024
@CyanVoxel
Copy link
Member

I don't believe generating smaller resulting images for large images would improve rendering times, as the entire file would still need to be parsed and re-rendered (outside of anything like progressive decoding, but the vast majority of images are not .jxl).

A couple alternative solutions planned to help with this are thumbnail caching and loading the rest of the preview panel information while the previews render separately.

@CyanVoxel CyanVoxel added Type: Suggestion A suggestion for how a feature could be implemented Type: UI/UX User interface and/or user experience labels Sep 1, 2024
@BPplays
Copy link
Contributor Author

BPplays commented Sep 1, 2024

@CyanVoxel
i might have explained what i want poorly, i meant i want to generate lower res images and have them saved to disk to be loaded first later, then the full res version displayed after it loaded.

@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Dec 21, 2024
@CyanVoxel CyanVoxel self-assigned this Dec 21, 2024
@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention and removed Type: Suggestion A suggestion for how a feature could be implemented labels Dec 21, 2024
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Dec 21, 2024
@CyanVoxel CyanVoxel moved this from 🛠 Ready for Development to 🚧 In progress in TagStudio Development Dec 21, 2024
@github-project-automation github-project-automation bot moved this from 🚧 In progress to ✅ Done in TagStudio Development Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants