+use on brush doors doesn't open them

[wgetJane]

1. download example map: https://steamcommunity.com/sharedfiles/filedetails/?id=3183036324

2. load map in ttt2

3. try to press E on any door (rotating or sliding doors)

4. it doesn't work

seems like a pretty severe issue

is there any reason why ttt2 needs to mess with the default +use behaviour on doors in the first place? seems like it just leads to a lot of breakage especially since it appears these changes barely get tested (if at all)

seems to be related to #1691 (from 3 months ago)

[TimGoll]

is there any reason why ttt2 needs to mess with the default +use behaviour on doors in the first place?

I'm not happy with this either. There's the issue with clientside interactions such as marker vision. This then caused issues which brought more fixes.

I'm almost considering reverting all of this. However, reverting fixes the issue with doors, but brings back some other old issues (like delayed opening of UIs when your ping is bad, no way of getting useful data from buttons etc)

This issue is also related to the issue with unusable vehicles on some maps

[wgetJane]

(like delayed opening of UIs when your ping is bad, no way of getting useful data from buttons etc)

those seem like much less severe issues than doors not working at all

it should at least be reverted for func_door and func_door_rotating for now

[wgetJane]

i think you shouldn't modify the default +use behaviour at all unless you really want to deal with all the headache that comes with it

you can still have the "Press E to use" stuff, not sure why you'd need to change how +use works at all

here's how you can replicate FindUseEntity clientside: https://github.com/ValveSoftware/source-sdk-2013/blob/master/src/game/shared/baseplayer_shared.cpp#L1067

im genuinely just very confused now that apparently this issue was known but was just left as-is because the loss of functionality for a bunch of doors in a bunch of maps was deemed a worthy tradeoff for something that's purely cosmetic

[TimGoll]

im genuinely just very confused now that apparently this issue was known but was just left as-is because the loss of functionality for a bunch of doors in a bunch of maps was deemed a worthy tradeoff for something that's purely cosmetic

At the time it wasn't know. It became clear after the release. But to our understanding it only affected a single map and vehicles on two maps. So we assumed it was ok. That it applies to ALL doors of that type wasn't clear to me. I tested it on so many maps, but apparently the wrong maps.

When I finished my vgui rewrite, I will redo the use handling. Because I'm unhappy as well. I think it might also be the reason the doorbuster stopped working.

Sidenote: I get that it is frustrating, but currently I'm happy if I have 4 or so hours per week to work on TTT2. I wish I'd could spend a day or two a week on TTT2. As much as I hated covid, I miss the days of non-stop coding for this project.

[wgetJane]

actually i just realised, you dont need to replicate FindUseEntity clientside, because the targetid thing only shows up when you have the useable entity directly on your crosshair, and the game prioritises using entities on your crosshair

i'm really really confused now why this was done in the first place

[wgetJane]

im gonna gonna see if i can make a quick fix for it and hopefully there'll be a hotfix soon

edit: i spoke too soon, i did not know the extent of this

[wgetJane]

another thing: you can open doors by pressing E on stuff parented to doors (like glass), but ttt2 breaks this

(just check GetParent() too, or GetMoveParent() i dont remember exactly, i check it for my door-kicking code)

[wgetJane]

ok reading more of the custom door code, i do not understand at all why the +use functionality was even tampered with

all the new fancy ui stuff is completely possible with networked vars with the default +use behaviour
(and preferably nw2vars rather than nw1vars to respect pvs and use less bandwidth)

delayed opening of UIs when your ping is bad

what ui are delayed? you can just override stuff that have a "clientside use" (like t buttons like base ttt does) and let normal +use fall through

also another thing i found: ttt2 breaks the "don't let crowbar open doors" setting

[wgetJane]

im really just baffled that so much work went into trying to replicate +use for seemingly no reason, idk what to even think, im not even trying to be rude im just so confused

[wgetJane]

and like did nobody try to press E on a sliding door throughout the whole process of coding it

i returned to playing ttt2 since like a week ago and i'm immediately finding all these issues

[wgetJane]

@TimGoll can you give like a brief summary of the use + door stuff and what issues there were when trying to revert it, i wanna know if im going insane or not

[TimGoll]

im really just baffled that so much work went into trying to replicate +use for seemingly no reason, idk what to even think, im not even trying to be rude im just so confused

I don't want to shift the blame to someone else here, so don't get me wrong. Someone else in the team made a light rework of the use. That broke a lot of things. I thought I could fix this and dug a deep hole over multiple PRs until I addressed all issues (seemingly). At some point I should have made the call to revert all of it, but I assumed I could just fix it.

[TimGoll]

and like did nobody try to press E on a sliding door throughout the whole process of coding it

i returned to playing ttt2 since like a week ago and i'm immediately finding all these issues

Probably different map pool then my testing set. Now that I think of it, I don't have any map with sliding doors in it. And besides you, nobody really bothered reporting anything. I don't play much myself and in the YT videos I've seen of people playing TTT2, none of these issues arose.