Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Toast When Using Replace File #788

Closed
locuturus opened this issue Feb 18, 2024 · 4 comments
Closed

Incorrect Toast When Using Replace File #788

locuturus opened this issue Feb 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@locuturus
Copy link

locuturus commented Feb 18, 2024

Describe the bug
When replacing a file the newly modified file overwrites the original. However, the toast says 'saved to Documents/ResizedImages folder' instead of wherever it really is saved.

To Reproduce
Set the filename option to replace the source file. Then edit and replace some file not already in /Documents/ResizedImages. In case it matters, I was using the resize and convert tool.

Expected behavior
I expect the toast to accurately reflect the actual save directory.

Screenshots

Smartphone (please complete the following information):

  • Device: Xperia 1 V
  • OS: Android 14
@locuturus locuturus added the bug Something isn't working label Feb 18, 2024
@T8RIN
Copy link
Owner

T8RIN commented Feb 18, 2024

It cannot reflect the directory, but should say that it's saved to its original destination, I'll look, thanks :)

@T8RIN
Copy link
Owner

T8RIN commented Feb 18, 2024

Tested right now, it's working for me, could you record a video for it please?

@T8RIN T8RIN closed this as completed Feb 18, 2024
T8RIN added a commit that referenced this issue Feb 18, 2024
Fix for Incorrect Toast When Using Replace File by #788
refactored injection and improved some things
@locuturus
Copy link
Author

I confirm the update changed the toast. If you're curious I attached a video showing what the previous version did.

Oh, and I suspect you can get the actual path in many circumstances. Action getcontent returns a URI you can parse if it's coming from com.android.externalstorage. But if it's coming from some other provider, like mediastore, then maybe not. Unless you can read the data column with the media permissions?

I don't know, I'm spitballing. What you chose to do is probably the best option.

VideoCreator_20240218_2_093911.mp4

@T8RIN
Copy link
Owner

T8RIN commented Feb 18, 2024

I've tried it before, but it has not worked at all, i m using mediastore btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants