fix: disable the type-only transform (#341)

Author: kricsleo

src/transform/Transformer.ts

@@ -1,9 +1,8 @@
 import type * as ESTree from "estree";
 import ts from "typescript";
-import { convertExpression, convertTypeOnlyHintStatement, createIdentifier, createProgram, withStartEnd } from "./astHelpers.js";
+import { convertExpression, createIdentifier, createProgram, withStartEnd } from "./astHelpers.js";
 import { DeclarationScope } from "./DeclarationScope.js";
 import { UnsupportedSyntaxError } from "./errors.js";
-import { parseTypeOnlyName } from "./TypeOnlyFixer.js";
 
 type ESTreeImports = ESTree.ImportDeclaration["specifiers"];
 
@@ -166,10 +165,17 @@ class Transformer {
   }
 
   convertTypeAliasDeclaration(node: ts.TypeAliasDeclaration) {
-    if(parseTypeOnlyName(node.name.text).isTypeOnly) {
-      this.pushStatement(convertTypeOnlyHintStatement(node))
-      return
-    }
+    /**
+     * TODO: type-only import/export fixer.
+     * Temporarily disable the type-only import/export transformation,
+     * because the current implementation is unsafe.
+     * 
+     * Issue: https://github.com/Swatinem/rollup-plugin-dts/issues/340
+     */
+    // if(parseTypeOnlyName(node.name.text).isTypeOnly) {
+    //   this.pushStatement(convertTypeOnlyHintStatement(node))
+    //   return
+    // }
 
     const scope = this.createDeclaration(node, node.name);
 

src/transform/TypeOnlyFixer.ts

@@ -195,22 +195,29 @@ export class TypeOnlyFixer {
         this.DEBUG && console.log(`${node.name.getFullText()} is a type`);
         this.types.add(alias);
 
-        if (ts.isTypeReferenceNode(node.type) && ts.isIdentifier(node.type.typeName)) {
-          const reference = node.type.typeName.text;
-          const aliasHint = parseTypeOnlyName(alias);
-
-          if(aliasHint.isTypeOnly) {
-            this.DEBUG && console.log(`${reference} is a type (from type-only hint)`);
-            this.types.add(reference);
-            this.typeHints.set(reference, (this.typeHints.get(reference) || 0) + 1);
-            if(aliasHint.isReExport) {
-              const reExportName = alias.split(TYPE_ONLY_RE_EXPORT)[0]!
-              this.DEBUG && console.log(`${reExportName} is a type (from type-only re-export hint)`);
-              this.reExportTypeHints.set(reExportName, (this.reExportTypeHints.get(reExportName) || 0) + 1);
-            }
-            this.code.remove(node.getStart(), node.getEnd());
-          }
-        }
+        /**
+         * TODO: type-only import/export fixer.
+         * Temporarily disable the type-only import/export transformation,
+         * because the current implementation is unsafe.
+         * 
+         * Issue: https://github.com/Swatinem/rollup-plugin-dts/issues/340
+         */
+        // if (ts.isTypeReferenceNode(node.type) && ts.isIdentifier(node.type.typeName)) {
+        //   const reference = node.type.typeName.text;
+        //   const aliasHint = parseTypeOnlyName(alias);
+
+        //   if(aliasHint.isTypeOnly) {
+        //     this.DEBUG && console.log(`${reference} is a type (from type-only hint)`);
+        //     this.types.add(reference);
+        //     this.typeHints.set(reference, (this.typeHints.get(reference) || 0) + 1);
+        //     if(aliasHint.isReExport) {
+        //       const reExportName = alias.split(TYPE_ONLY_RE_EXPORT)[0]!
+        //       this.DEBUG && console.log(`${reExportName} is a type (from type-only re-export hint)`);
+        //       this.reExportTypeHints.set(reExportName, (this.reExportTypeHints.get(reExportName) || 0) + 1);
+        //     }
+        //     this.code.remove(node.getStart(), node.getEnd());
+        //   }
+        // }
         continue;
       }
 

src/transform/preprocess.ts

@@ -194,8 +194,15 @@ export function preProcess({ sourceFile, isEntry, isJSON }: PreProcessInput): Pr
     // recursively check inline imports
     checkInlineImport(node);
 
-    transformTypeOnlyImport(node);
-    transformTypeOnlyExport(node);
+    /**
+     * TODO: type-only import/export fixer.
+     * Temporarily disable the type-only import/export transformation,
+     * because the current implementation is unsafe.
+     * 
+     * Issue: https://github.com/Swatinem/rollup-plugin-dts/issues/340
+     */
+    // transformTypeOnlyImport(node);
+    // transformTypeOnlyExport(node);
 
     if (!matchesModifier(node, ts.ModifierFlags.ExportDefault)) {
       continue;
@@ -305,6 +312,7 @@ export function preProcess({ sourceFile, isEntry, isJSON }: PreProcessInput): Pr
     fileReferences,
   };
 
+  // @ts-expect-error temporary disabled
   function transformTypeOnlyImport(node: ts.Node) {
     if (!ts.isImportDeclaration(node) || !node.importClause) {
       return;
@@ -351,6 +359,7 @@ export function preProcess({ sourceFile, isEntry, isJSON }: PreProcessInput): Pr
     }
   }
 
+  // @ts-expect-error temporary disabled
   function transformTypeOnlyExport(node: ts.Node) {
     if(!ts.isExportDeclaration(node)) {
       return;

tests/testcases/custom-tsconfig/expected.d.ts

@@ -1,3 +1,2 @@
 interface Foo {}
-//@ts-expect-error
 export type { Foo };

tests/testcases/type-only-import-export/meta.js

@@ -0,0 +1,12 @@
+// @ts-check
+
+/** @type {import('../../testcases').Meta} */
+export default {
+  options: {},
+  rollupOptions: {},
+  /**
+   * TODO: Until we found a safe way to handle the type-only import/export, 
+   * we skip this test.
+   */
+  skip: true,
+};