fixed the reader view navbar color when in lightmode #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaMoradi
requested changes
Oct 16, 2021
- Added the package-lock.json
|
I made the changes requested |
AriaMoradi
requested changes
Oct 16, 2021
AriaMoradi
reviewed
Oct 16, 2021
|
|
||
| '& header': { | ||
| backgroundColor: '#363b3d', | ||
| backgroundColor: | ||
| theme.palette.mode === 'dark' ? '#363b3d' : theme.palette.grey[100], | ||
| display: 'flex', |
There was a problem hiding this comment.
Is there any suitable replacement for #363b3d and #0a0b0b in the dark theme pallette? I took those colors from a similar app but neither are mui standard colors, so replacing them here and now would be nice.
There was a problem hiding this comment.
https://next.material-ui.com/customization/dark-mode/
I used this for the chapter hover thing
the #0a0b0b might be comparable to the palette.background.default
maybe using the grey pallete?
https://materialui.co/colors
There was a problem hiding this comment.
So made the navbar use colors from the Theme object. Replaced the colors from the closest counter parts available
AriaMoradi
requested changes
Oct 17, 2021
…e Theme object in Material UI
AriaMoradi
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
The Navbar in reader view is now adopting background colors to light mode