POST variant for /{sourceId}/search endpoint
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data as list of FilterChanges
AriaMoradi
approved these changes
Nov 4, 2022
|
Make the changes as discussed on discord.
|
AriaMoradi
requested changes
Nov 5, 2022
martinek
deleted the
feature/post-transient-filter-with-search-in-single-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows client to call search endpoint with filter values in request body.
Client will be able to simply load source filters and query the source directly, without needing to update filters on server before calling search. This should allow for easier state management and filtering on client.
The filters in body are merged with original source
FilterListto prevent unexpected values fromfilterListCache. Also they are not stored to server cache, so using them have no effect onfilterListCache.