Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scripts #370

Merged
merged 7 commits into from
Jul 2, 2022
Merged

Refactor scripts #370

merged 7 commits into from
Jul 2, 2022

Conversation

mahor1221
Copy link
Contributor

@mahor1221 mahor1221 commented Jul 1, 2022

  • Merged debian-packager.sh, unix-bundler.sh and windows-bundler.sh into one unified shell script which is easier to read and maintain.

  • Added error handler

  • Commented out the wine installation and rcedit section due to E: Unable to correct problems, you have held broken packages. and wine: command not found errors which didn't stop the workflow from progressing without adding an error handler. This problem has existed forever I guess. Ubuntu just refuses to install wine.

  • Replaced debuild with dpkg-buildpackage. dpkg-buildpackage is a simpler tool

Test run: https://github.com/mahor1221/Tachidesk-Server/actions/runs/2596322318

@mahor1221 mahor1221 changed the title Refactor scripts [Enhancment] Refactor scripts Jul 1, 2022
@mahor1221 mahor1221 changed the title [Enhancment] Refactor scripts [Enhanc] Refactor scripts Jul 1, 2022
@mahor1221 mahor1221 changed the title [Enhanc] Refactor scripts Refactor scripts Jul 2, 2022
@Syer10 Syer10 merged commit ed18012 into Suwayomi:master Jul 2, 2022
@mahor1221 mahor1221 deleted the enhanc/refactor-scripts branch December 15, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants