Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Space/Tap/Click should Scroll down the page instead of going to next image #162

Closed
alkumaish opened this issue Mar 12, 2022 · 2 comments · Fixed by #200
Closed

[Bug] Space/Tap/Click should Scroll down the page instead of going to next image #162

alkumaish opened this issue Mar 12, 2022 · 2 comments · Fixed by #200
Labels
bug Something isn't working

Comments

@alkumaish
Copy link

alkumaish commented Mar 12, 2022

Device information

  • Tachidesk version: v0.6.2-r1074-linux-x64
  • Server JVM version: OpenJDK 8u312
  • Client Operating System: Same or Android
  • Client Web Browser: Chrome/Firefox

Steps to reproduce

  1. Open a comic with large images
  2. Make it so that you'll need to scroll down to see the full image (or just open a webtoon, they have long pages)
  3. Click space or tap/click on the "next" area.

Expected behavior

Space/Tap/Click should Scroll down the page instead of going to next image

Actual behavior

Space/Tap/Click will take you to the next image regardless of how much you actually read/viewed.

Other details

This behavior is more apparent when reading in "Webtoon" or "Continuous vertical" mode, and especially with webcomics/webtoons as they have very long images.

@alkumaish alkumaish added the bug Something isn't working label Mar 12, 2022
@alkumaish
Copy link
Author

Skipping to next page is great anyway, but maybe another set of keys should be assigned to skip pages instead of Space?

Also having more touch/tap/click areas (i.e. bottom/upper areas for scrolling down/up) makes more sense (maybe also have them change according to "reading type"?)

The more I think about it, the more I realise I should've filed this "issue" as a feature request/enhancement.

@Robonau
Copy link
Contributor

Robonau commented Mar 12, 2022

magic scroll might be the most useful
scrolls to the next page if the next page is visible or of there is no new pages then scrolls 80% of the view-port

https://github.com/manga-download/hakuneko/blob/e686c540bdf19421eca9862b9c42355342178385/src/web/lib/hakuneko/frontend%40classic-light/pages.html#L554

it describes it as "ugly with webtoons" but it works perfectly

(this not being implemented is the main reason that i don't use the tachidesk reader)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants