fix(tasks): parse malformed quest titles

imagine if these were consistent 😠

Author: SugarF0x

src/views/Tasks/hooks/useParser/getTask.ts

@@ -8,6 +8,7 @@ import {
   WorshipTask,
 } from "../../store"
 import { getType } from "./getType"
+import { getCardText } from "./utils"
 
 const complexTaskToParserMap: Record<ComplexTaskType, (el: HTMLElement) => Task> = {
   [TaskType.WORSHIP]: getWorshipTask,
@@ -53,15 +54,6 @@ function getText(el: HTMLElement): string {
   return el.querySelector<HTMLSpanElement>("span.truncate")?.innerText ?? ""
 }
 
-function getCardText(el: HTMLElement): string {
-  const onclickData = el.getAttribute("onclick")
-  if (!onclickData) return "No meta found"
-
-  const meta = onclickData.slice(onclickData.indexOf("('")).replace(/[)(]/g, "")
-  const parsedMeta = JSON.parse(`[${meta.replace(/"/g, '\\"').replace(/'/g, '"')}]`)
-  return parsedMeta[1]
-}
-
 function getKillSomeTask(el: HTMLElement): KillSomeTask {
   const [progress, requirement] = getProgress(el)
   const [title, icon] = getMeta(el)
@@ -91,8 +83,8 @@ function getQuestSomeTask(el: HTMLElement): QuestSomeTask {
   const [progress, requirement] = getProgress(el)
   const [title, icon] = getMeta(el)
 
-  const text = getText(el)
-  const target = text.match(/(?<=Complete the quest )(.*)(?= [0-9])/g)?.[0] ?? "UNKNOWN TARGET"
+  const cardText = getCardText(el)
+  const target = cardText.match(/(?<=Complete the quest )(.*)(?= [0-9])/g)?.[0]?.replace(/"/g, "") ?? "UNKNOWN TARGET"
 
   return {
     type: TaskType.QUEST_SOME,

src/views/Tasks/hooks/useParser/getType.ts

@@ -1,4 +1,5 @@
 import { TaskType } from "../../store"
+import { getCardText } from "@/views/Tasks/hooks/useParser/utils"
 
 const regexpToTypeMap: Array<[RegExp, TaskType]> = [
   [/kill.*times/gi, TaskType.KILL_SOME],
@@ -12,7 +13,7 @@ const regexpToTypeMap: Array<[RegExp, TaskType]> = [
 ]
 
 export function getType(el: HTMLElement): TaskType {
-  const text = el.querySelector<HTMLSpanElement>("span.truncate")?.innerText || ""
+  const text = getCardText(el)
   const [_, type] = regexpToTypeMap.find(([regexp]) => text.match(regexp)) ?? []
   return type ?? TaskType.UNKNOWN
 }

src/views/Tasks/hooks/useParser/utils.ts

@@ -0,0 +1,8 @@
+export function getCardText(el: HTMLElement): string {
+  const onclickData = el.getAttribute("onclick")
+  if (!onclickData) return "No meta found"
+
+  const meta = onclickData.slice(onclickData.indexOf("('")).replace(/[)(]/g, "")
+  const parsedMeta = JSON.parse(`[${meta.replace(/"/g, '\\"').replace(/'/g, '"')}]`)
+  return parsedMeta[1]
+}

src/views/Tasks/store.ts

@@ -62,15 +62,15 @@ export const useTasksStore = defineStore(
 )
 
 export enum TaskType {
-  QUEST_SOME,
-  QUEST_ANY,
-  KILL_SOME,
-  KILL_ANY,
-  STEP,
-  WORSHIP,
-  VOTE,
-  BUY,
-  UNKNOWN,
+  QUEST_SOME = "QUEST_SOME",
+  QUEST_ANY = "QUEST_ANY",
+  KILL_SOME = "KILL_SOME",
+  KILL_ANY = "KILL_ANY",
+  STEP = "STEP",
+  WORSHIP = "WORSHIP",
+  VOTE = "VOTE",
+  BUY = "BUY",
+  UNKNOWN = "UNKNOWN",
 }
 
 export type ComplexTaskType = Extract<TaskType, TaskType.WORSHIP | TaskType.QUEST_SOME | TaskType.KILL_SOME>