Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PropTypes from package in favor of newly-supported Flow metadata.json in dash #57

Closed
mjclawar opened this issue Feb 22, 2018 · 0 comments

Comments

@mjclawar
Copy link
Member

Description

plotly/dash#207 updates to support flow types in v0.21.0

Dash now supports React components that use Flow. To support Flow, component_loader now has the following behavior to create docstrings as determined in discussion in #187: 1. If a Dash component has PropTypes-generated typing, the docstring uses the PropTypes, regardless of whether the component also has Flow types (current behavior). 2. Otherwise if a Dash component has Flow types but not PropTypes, the docstring now uses the objects generated by react-docgen from the Flow types.

We can now remove PropTypes entirely from the package and, where necessary, update Flow to mimic the types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants