-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better logs V2 #2376
Merged
Merged
Better logs V2 #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailed, if any. Added clearer errors to help determine what may be wrong
…ary, instead passing the direct reason like "stop" or "quit". made log one line, breaking up the the information into readable chunks rather than a heap of information.
Both pendingMessagePart and finalMessage contain the same information, causing bloat while logging. Did not remove any information, so the log would contain everything the previous log had. Reduced finalMessage.text to only allow up to 45 characters would ever be shown (removing new lines as well). finalMessage.media is often an empty array (and blocked most times anyway), so added logic to state no media if the array is empty.
…rganization variable in test to pass as the new error contains which organization is causing said error.
…ll organization.name after failing. This is in response to creating better errors that point towards which organization is causing said errors.
mau11
approved these changes
Jul 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Creates clearer, common occurring logs.
Description
Most information found in
console.logs
was jumbled, which benefitted from destructuring.Others, like
getConversation
were confusing. Take a look at the old log:Here,
undefined
, dealt with awsContext, which is not apparent when looking at the log. Paired withundefined
being followed bysql
, caused some concern when not privy to what theconsole.log
looks like. However,getConversations sql
is a string within the log, and does not call any variable.Will now read like:
Most changes to any
console.log
follows a similar destructuring.Additionally, most errors, like those commonly found when NGP VAN is not configured correctly, did not share what organization was causing the problem. This update focused on including org ids and other supporting information to help pinpoint any misconfiguration. This is most apparent in multi org situations.
Checklist: