Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dotenv to 16.4.5 #2370

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

stefanhayden
Copy link
Collaborator

Fixes # (issue)

Description

dotenv from 2.0.0 to 16.4.5

changelog here. nothing breaking seems to effect this app. https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben
Copy link
Collaborator

engelhartrueben commented Jun 12, 2024

Thanks for spotting this.
Once we get the 14.1 branch ready, we will review and merge this in.

More for my sake when coming back to this: dotenv 15.0.0 breaks # when used in a variable as it considers it a comment, unless wrapped in quotes. Looking into our current build, we don't use # other than comments, but may be good to mention in the release notes. This is more for local development, as pm2 already requires quotes when running prod, while yarn dev does not.

@engelhartrueben engelhartrueben changed the base branch from new-node-20-branch to stage-main-14.1 July 3, 2024 14:09
@engelhartrueben
Copy link
Collaborator

Hey @stefanhayden,
Can you rebase this as well to get up to date with stage-main-14.1?

@stefanhayden stefanhayden force-pushed the stefanhayden/dotenv-upgrade-16.4.5 branch from 06b26fa to 47271e5 Compare July 10, 2024 22:38
@stefanhayden
Copy link
Collaborator Author

@engelhartrueben rebased!

@engelhartrueben engelhartrueben merged commit 0cdb65e into stage-main-14.1 Jul 11, 2024
17 checks passed
@engelhartrueben engelhartrueben mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 14.1
Development

Successfully merging this pull request may close these issues.

2 participants