NAMECHEAP: fix support for url etc records

[willpower232]

Resolves #3522

The custom record types URL, URL301, and FRAME can be created by the current version of dnscontrol but they cannot be read by subsequent calls.

It looks like the previous iteration of how things work defaulted to record.SetTarget whereas the current way relies on record.PopulateFromString which does not have support for the custom record types.

This small change appears to do the trick to resolve the problem, the type specified from the users config file makes it way to the commands to create the records no problem.

I am not sure how to write tests for this since it would be namecheap specific? It looks like vultr also supports the records but I do not have a vultr account to confirm if it currently works or not.

P.S. I edited the file in github, not sure why it is showing as unverified by maybe thats just github being silly.

P.P.S. now showing as verified, github silliness confirmed

[tlimoncelli]

Thanks for finding and fixing this bug!

You can add integration tests that are specific to a provider with the only() function. For example...

dnscontrol/integrationTest/integration_test.go

Line 1871 in bb7f881

testgroup("PORKBUN_URLFWD tests",

		// PORKBUN features

		testgroup("PORKBUN_URLFWD tests",
			only("PORKBUN"),
			tc("Add a urlfwd", porkbunUrlfwd("urlfwd1", "http://example.com", "", "", "")),
			tc("Update a urlfwd", porkbunUrlfwd("urlfwd1", "http://example.org", "", "", "")),
			tc("Update a urlfwd with metadata", porkbunUrlfwd("urlfwd1", "http://example.org", "permanent", "no", "no")),
		),

[labrown]

I can confirm this change fixes my issue. Thanks!

[willpower232]

tests working nicely, thanks for the steer @tlimoncelli